OCTOPUS-625:Added playbook vars files #16
Conversation
Signed-off-by: Punith Kenchappa <[email protected]>
| hosts: all | ||
| vars_files: | ||
| - ../../../../vars/main.yml | ||
| - name: Download the Image from the URL and use to create image |
There was a problem hiding this comment.
What do you think about kebab case so we follow a consistent role?
centosImage-create we should change to centos-image-create
we'd update rhcos too. I think we can leave this for the next PR (if it makes sense)
There was a problem hiding this comment.
yes , I thought to have centos-image-create , but ansible-lint was giving me error for this name with twice - in the name , so because of this , thought to name it as centosImage-create .
| hosts: all | ||
| roles: | ||
| - rhcosImage-create | ||
| tasks: |
There was a problem hiding this comment.
Ansible warning... unexpected parameter type in action: <class 'ansible.parsing.yaml.objects.AnsibleSequence'>
I'm wondering if we need something changed here.
There was a problem hiding this comment.
I tried to make some changes here , even in the doc , I did not get what's wrong here , there is no proper explanation why it's wrong .
There was a problem hiding this comment.
oh! that makes sense to me... thanks for checking
| cpu_arch: "{{ image_cpu_arch_centos }}" | ||
| distro: "{{ image_distro_centos }}" | ||
| - name: Remove Centos images to openstack. | ||
| openstack.cloud.image: |
There was a problem hiding this comment.
I wonder if we need to add e requirements.yaml #17 it might clean up the warning.
This PR is to add the vars files for the respective roles .