-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the tests: deliversCleanOutput and executesJvmFullRun #2631
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1b8326e
#2591 enable tests
c71n93 cdce6ea
#2591 remove todo
c71n93 a3ac3fa
#2591 fix javadoc
c71n93 0912fb5
#2591 enable deliversCleanOutput test
c71n93 df31e60
Merge branch 'master' into 2591-enable-tests
c71n93 bcff358
#2591 enable executesJvmFullRun test
c71n93 d9339ae
#2591 fix checkstyle
c71n93 6fe3390
#2591 remove unused imports
c71n93 242cdaa
#2591 add todo
c71n93 7ac399f
#2591 fix todo
c71n93 8d43a83
#2591 fix todo
c71n93 a8fffc7
#2591 fix todo
c71n93 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,7 +24,6 @@ | |
|
||
package org.eolang; | ||
|
||
import EOorg.EOeolang.EOstring; | ||
import java.io.BufferedReader; | ||
import java.io.IOException; | ||
import java.io.InputStreamReader; | ||
|
@@ -172,6 +171,9 @@ private static boolean parse(final String opt) throws IOException { | |
* Run this opts. | ||
* @param opts The opts left | ||
* @throws Exception If fails | ||
* @todo #2591:60min Make type casting when logging an app dataization result. The cast is | ||
* necessary in this expression {@code new Data set(app).take()} in order to correctly | ||
* convert it to a string. This conversion it necessary for proper logging. | ||
*/ | ||
private static void run(final List<String> opts) throws Exception { | ||
final String path = new JavaPath(opts.get(0)).toString(); | ||
|
@@ -188,15 +190,12 @@ private static void run(final List<String> opts) throws Exception { | |
); | ||
} | ||
for (int idx = 1; idx < opts.size(); ++idx) { | ||
final Phi phi = new EOstring(Phi.Φ); | ||
final String arg = opts.get(idx); | ||
phi.attr("Δ").put(new Data.Value<>(arg)); | ||
app.attr(0).put(phi); | ||
app.attr(0).put(new Data.ToPhi(opts.get(idx))); | ||
} | ||
Main.LOGGER.info( | ||
String.format( | ||
"%n---%n%s", | ||
new Dataized(app).take().toString() | ||
Arrays.toString(new Dataized(app).take()) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @c71n93 let's add a puzzle here so we won't forget to make up with some type casting here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @maxonfjvipon done. Could you check, please? |
||
) | ||
); | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c71n93 I didn't really get what the expression in the {@code ...} means
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a code snippet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c71n93 I see but what
new Data set(app)
means?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxonfjvipon It is an expression, that needs to be casted to an appropriate type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c71n93 is it a valid Java code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c71n93 maybe you meant Dataized instead of Data set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxonfjvipon Oh, yeah, didn't notice the mistake, thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxonfjvipon done