Enable the tests: deliversCleanOutput and executesJvmFullRun #2631
Conversation
|
@maxonfjvipon could you check this one, please? |
| Matchers.containsString("\uD835\uDD3B( "), | ||
| Matchers.containsString("string") | ||
| ) | ||
| Matchers.containsString("Error at \"EOorg.EOeolang.EOstring#as-bytes\" attribute") |
There was a problem hiding this comment.
@c71n93 I think the main goal of the test - emulate the launch of the EO program via console.
After your changes we got the situation where we launch it and get an error. I believe it's wrong.
It would be better to change something in MainTest.exec() method call so we would not get an error.
There was a problem hiding this comment.
@maxonfjvipon done. Could you check, please?
| } | ||
| Main.LOGGER.info( | ||
| String.format( | ||
| "%n---%n%s", | ||
| new Dataized(app).take().toString() | ||
| Arrays.toString(new Dataized(app).take()) |
There was a problem hiding this comment.
@c71n93 let's add a puzzle here so we won't forget to make up with some type casting here
There was a problem hiding this comment.
@maxonfjvipon done. Could you check, please?
| @@ -172,6 +171,9 @@ private static boolean parse(final String opt) throws IOException { | |||
| * Run this opts. | |||
| * @param opts The opts left | |||
| * @throws Exception If fails | |||
| * @todo #2591:60min Make type casting when logging an app dataization result. The cast is | |||
| * necessary in this expression {@code new Data set(app).take()} in order to correctly | |||
There was a problem hiding this comment.
@c71n93 I see but what new Data set(app) means?
There was a problem hiding this comment.
@maxonfjvipon It is an expression, that needs to be casted to an appropriate type.
There was a problem hiding this comment.
@c71n93 is it a valid Java code?
There was a problem hiding this comment.
@c71n93 maybe you meant Dataized instead of Data set?
There was a problem hiding this comment.
@maxonfjvipon Oh, yeah, didn't notice the mistake, thank you
|
@yegor256 could you check this one, please? |
|
@rultor merge |
Closes #2591
PR-Codex overview
This PR focuses on enabling and fixing two tests in the
MainTestclass.Detailed summary
java.util.Arraysadded inMainTest.java.@Disabledannotations removed fromdeliversCleanOutput()andexecutesJvmFullRun()methods inMainTest.java.run()method inMain.java.