-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made eq attribute of standard objects int
and float
to meet the standards (IEEE 754)
#2554
Merged
Merged
Changes from 15 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c83b830
#2547 make int.eq an atom
c71n93 01c7c88
#2547 turn off broken tests and add todo
c71n93 93e3352
#2547 make float.eq an atom
c71n93 80a0dc9
#2547 turn off broken float tests and add todo
c71n93 c1d254a
#2547 turn off some infinity tests
c71n93 d583bbb
#2547 fix qulice
c71n93 67eb95b
#2547 fix codacy
c71n93 c22035b
#2547 fix description
c71n93 aa85dc0
#2547 make reinterpret type conversion for int.eq
c71n93 e9aac1e
#2547 resolve int tests
c71n93 b26849c
#2547 make reinterpret type conversion for float.eq
c71n93 836218a
#2547 resolve float tests
c71n93 4afea18
#2547 resolve infinite tests
c71n93 a88f3b1
#2547 add additional tests
c71n93 0f749fe
#2547 fix naming
c71n93 7d85d31
#2547 implement int.eq in EO
c71n93 5805dc7
#2547 implement float.eq in EO
c71n93 6d432f6
#2547 add tests for float.eq
c71n93 45873bc
#2547 fix tests
c71n93 2d32988
#2547 fix codacy
c71n93 a7e7c71
#2547 optimize float.eq
c71n93 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
/* | ||
* The MIT License (MIT) | ||
* | ||
* Copyright (c) 2016-2023 Objectionary.com | ||
* | ||
* Permission is hereby granted, free of charge, to any person obtaining a copy | ||
* of this software and associated documentation files (the "Software"), to deal | ||
* in the Software without restriction, including without limitation the rights | ||
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
* copies of the Software, and to permit persons to whom the Software is | ||
* furnished to do so, subject to the following conditions: | ||
* | ||
* The above copyright notice and this permission notice shall be included | ||
* in all copies or substantial portions of the Software. | ||
* | ||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
* FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE | ||
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
* SOFTWARE. | ||
*/ | ||
|
||
/* | ||
* @checkstyle PackageNameCheck (4 lines) | ||
*/ | ||
package EOorg.EOeolang; | ||
|
||
import org.eolang.AtComposite; | ||
import org.eolang.AtFree; | ||
import org.eolang.Data; | ||
import org.eolang.Param; | ||
import org.eolang.PhDefault; | ||
import org.eolang.Phi; | ||
import org.eolang.Versionized; | ||
import org.eolang.XmirObject; | ||
|
||
/** | ||
* EQ. | ||
* | ||
* @since 0.33 | ||
* @checkstyle TypeNameCheck (5 lines) | ||
*/ | ||
@Versionized | ||
@XmirObject(oname = "float.eq") | ||
public class EOfloat$EOeq extends PhDefault { | ||
|
||
/** | ||
* Ctor. | ||
* @param sigma Sigma | ||
*/ | ||
public EOfloat$EOeq(final Phi sigma) { | ||
super(sigma); | ||
this.add("x", new AtFree()); | ||
this.add( | ||
"φ", | ||
new AtComposite( | ||
this, | ||
rho -> new Data.ToPhi( | ||
new Param(rho).asStrictBytes(Double.BYTES).asNumber(Double.class) == (double) | ||
new Param(rho, "x").asStrictBytes(Double.BYTES).asNumber(Double.class) | ||
) | ||
) | ||
); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
/* | ||
* The MIT License (MIT) | ||
* | ||
* Copyright (c) 2016-2023 Objectionary.com | ||
* | ||
* Permission is hereby granted, free of charge, to any person obtaining a copy | ||
* of this software and associated documentation files (the "Software"), to deal | ||
* in the Software without restriction, including without limitation the rights | ||
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
* copies of the Software, and to permit persons to whom the Software is | ||
* furnished to do so, subject to the following conditions: | ||
* | ||
* The above copyright notice and this permission notice shall be included | ||
* in all copies or substantial portions of the Software. | ||
* | ||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
* FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE | ||
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
* SOFTWARE. | ||
*/ | ||
|
||
/* | ||
* @checkstyle PackageNameCheck (4 lines) | ||
*/ | ||
package EOorg.EOeolang; | ||
|
||
import org.eolang.AtComposite; | ||
import org.eolang.AtFree; | ||
import org.eolang.Data; | ||
import org.eolang.Param; | ||
import org.eolang.PhDefault; | ||
import org.eolang.Phi; | ||
import org.eolang.Versionized; | ||
import org.eolang.XmirObject; | ||
|
||
/** | ||
* EQ. | ||
* | ||
* @since 0.33 | ||
* @checkstyle TypeNameCheck (5 lines) | ||
*/ | ||
@Versionized | ||
@XmirObject(oname = "int.eq") | ||
public class EOint$EOeq extends PhDefault { | ||
|
||
/** | ||
* Ctor. | ||
* @param sigma Sigma | ||
*/ | ||
public EOint$EOeq(final Phi sigma) { | ||
super(sigma); | ||
this.add("x", new AtFree()); | ||
this.add( | ||
"φ", | ||
new AtComposite( | ||
this, | ||
rho -> new Data.ToPhi( | ||
new Param(rho).asStrictBytes(Long.BYTES).asNumber(Long.class) == (long) | ||
new Param(rho, "x").asStrictBytes(Long.BYTES).asNumber(Long.class) | ||
) | ||
) | ||
); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c71n93 I think we don't need these lines here anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxonfjvipon done