Made eq attribute of standard objects `int` and `float` to meet the standards (IEEE 754) #2554

c71n93 · 2023-10-24T15:37:32Z

PR-Codex overview

Focus of this PR:

This PR focuses on making changes to the int and float classes in the eo-runtime module. It includes modifications to the eq and lt methods in both classes, as well as changes to the test files.

Detailed summary:

In eo-runtime/src/main/eo/org/eolang/int.eo:
- Modifications to the eq method to test if $ = x.
- Changes to the lt method to test if $ < x.
In eo-runtime/src/main/eo/org/eolang/float.eo:
- Modifications to the eq method to test if $ = x.
- Changes to the lt method to test if $ < x.
In eo-runtime/src/test/eo/org/eolang/int-tests.eo:
- Changes to the test cases for the eq method.
In eo-runtime/src/test/eo/org/eolang/float-tests.eo:
- Changes to the test cases for the eq and lt methods.
In eo-runtime/src/main/eo/org/eolang/float.eo:
- Modifications to the eq method to test if $ = x.
- Changes to the lt method to test if $ < x.
In eo-runtime/src/test/eo/org/eolang/float-tests.eo:
- Changes to the test cases for the eq and lt methods.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

c71n93 · 2023-10-24T15:39:10Z

@mximp could you check this one, please?

c71n93 · 2023-10-25T09:28:45Z

@maxonfjvipon could you check this one, please?

maxonfjvipon

@c71n93 Good one. Just two comments from my side

maxonfjvipon · 2023-10-25T09:31:20Z

eo-runtime/src/main/java/EOorg/EOeolang/EOint$EOeq.java

+import org.eolang.XmirObject;
+
+/**
+ * GT.


@c71n93 I think this description and @since tag are wrong

@maxonfjvipon done

maxonfjvipon · 2023-10-25T09:31:43Z

eo-runtime/src/main/java/EOorg/EOeolang/EOfloat$EOeq.java

+import org.eolang.XmirObject;
+
+/**
+ * GT.


@c71n93 I think this description and @since tag are wrong

@maxonfjvipon done

maxonfjvipon

@c71n93 LGTM! Thanks

c71n93 · 2023-10-26T16:09:50Z

@yegor256 @maxonfjvipon could you check this one, please? I made eq to reinterpret data as floating point for float and integer for int.

maxonfjvipon · 2023-10-26T18:54:50Z

eo-runtime/src/main/java/org/eolang/Param.java

+     * @param appropriate The appropriate size.
+     * @return Bytes.
+     */
+    public Bytes asBytesAppropriate(final int appropriate) {


@c71n93

The name of the method seems a bit long and verbose to me. Maybe we can make up with something shorter.
Maybe something like asStrictBytes, asPreciseBytes?

The word "bytes" should be in the end of the name of the method, and adjective should not. Because we still want to get "bytes".

variable appropriate is an adjective which seems a bit wrong. A believe it should be a noun since it's an integer number.

@maxonfjvipon Thanks, but could you provide me an example about the 3rd point? There are two variables with meaning size now: appropriate and size. I would like to name them appropriateSize and actualSize but it's compound naming.

@c71n93 what about length?

@maxonfjvipon fixed

maxonfjvipon

@c71n93 LGTM! Thanks

c71n93 · 2023-10-27T12:20:25Z

@yegor256 could you check, please?

yegor256 · 2023-10-27T12:22:55Z

@c71n93 why int.eq can't be implemented in EO?

c71n93 · 2023-10-27T13:00:27Z

@yegor256 It can, but why do we need to implement it in EO? float.eq is an atom, so why int.eq should not be?

yegor256 · 2023-10-27T13:02:37Z

@c71n93 good point. let's implement them both in EO

c71n93 · 2023-10-27T13:03:41Z

@yegor256 why then int.lt and float.lt should be atoms?

yegor256 · 2023-10-27T13:05:17Z

@c71n93 they also can be implemented in EO

c71n93 · 2023-10-27T13:08:25Z

@yegor256 It's not trivial task, especially for float.lt. Right off the bat I can't tell you how to do it. I think, this already looks like an unnecessary overcomplication.

yegor256 · 2023-10-27T16:14:22Z

@c71n93 we'll do gt and lt later

maxonfjvipon · 2023-10-30T11:41:40Z

.codacy.yml

+  - "eo-runtime/src/main/java/EOorg/EOeolang/EOfloat$EOeq.java"
+  - "eo-runtime/src/main/java/EOorg/EOeolang/EOint$EOeq.java"


@c71n93 I think we don't need these lines here anymore

@maxonfjvipon done

maxonfjvipon · 2023-10-30T11:43:27Z

eo-runtime/src/main/eo/org/eolang/float.eo

+          self-as-bytes
+          nan-as-bytes
+      FALSE
+      if.


@c71n93 I think this expression with if can be simplified with just or.

@maxonfjvipon done

c71n93 · 2023-10-30T16:23:14Z

@maxonfjvipon could you check again, please?

maxonfjvipon

@c71n93 Looks good to me! Thanks

c71n93 · 2023-10-30T18:31:07Z

@yegor256 could you check, please?

yegor256 · 2023-10-31T05:37:55Z

@rultor merge

rultor · 2023-10-31T06:04:49Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2023-10-31T06:26:13Z

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 21min)

c71n93 added 5 commits October 24, 2023 15:02

objectionary#2547 make int.eq an atom

c83b830

objectionary#2547 turn off broken tests and add todo

01c7c88

objectionary#2547 make float.eq an atom

93e3352

objectionary#2547 turn off broken float tests and add todo

80a0dc9

objectionary#2547 turn off some infinity tests

c1d254a

objectionary#2547 fix qulice

d583bbb

c71n93 force-pushed the 2547-atom-eq branch from 5a43814 to d583bbb Compare October 24, 2023 17:10

objectionary#2547 fix codacy

67eb95b

maxonfjvipon suggested changes Oct 25, 2023

View reviewed changes

c71n93 force-pushed the 2547-atom-eq branch from 1424fdb to 038925d Compare October 25, 2023 09:50

objectionary#2547 fix description

c22035b

c71n93 force-pushed the 2547-atom-eq branch from 038925d to c22035b Compare October 25, 2023 09:52

maxonfjvipon approved these changes Oct 25, 2023

View reviewed changes

c71n93 added 6 commits October 26, 2023 18:01

objectionary#2547 make reinterpret type conversion for int.eq

aa85dc0

objectionary#2547 resolve int tests

e9aac1e

objectionary#2547 make reinterpret type conversion for float.eq

b26849c

objectionary#2547 resolve float tests

836218a

objectionary#2547 resolve infinite tests

4afea18

objectionary#2547 add additional tests

a88f3b1

maxonfjvipon suggested changes Oct 26, 2023

View reviewed changes

objectionary#2547 fix naming

0f749fe

c71n93 force-pushed the 2547-atom-eq branch from 7084b4c to 0f749fe Compare October 27, 2023 11:37

maxonfjvipon approved these changes Oct 27, 2023

View reviewed changes

c71n93 mentioned this pull request Oct 30, 2023

Make eq attribute of standard objects (int, float, ...) to be an atom. #2547

Closed

c71n93 added 4 commits October 30, 2023 12:46

objectionary#2547 implement int.eq in EO

7d85d31

objectionary#2547 implement float.eq in EO

5805dc7

objectionary#2547 add tests for float.eq

6d432f6

objectionary#2547 fix tests

45873bc

maxonfjvipon suggested changes Oct 30, 2023

View reviewed changes

objectionary#2547 fix codacy

2d32988

c71n93 changed the title ~~Made eq attribute of standard objects int and float to be an atom~~ Made eq attribute of standard objects int and float to meet the standards (IEEE 754) Oct 30, 2023

objectionary#2547 optimize float.eq

a7e7c71

c71n93 force-pushed the 2547-atom-eq branch from c05a542 to a7e7c71 Compare October 30, 2023 13:02

maxonfjvipon approved these changes Oct 30, 2023

View reviewed changes

rultor merged commit 6545c3f into objectionary:master Oct 31, 2023
11 checks passed

c71n93 deleted the 2547-atom-eq branch March 20, 2024 14:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Made eq attribute of standard objects `int` and `float` to meet the standards (IEEE 754) #2554

Made eq attribute of standard objects `int` and `float` to meet the standards (IEEE 754) #2554

c71n93 commented Oct 24, 2023 •

edited by pr-codex bot

Loading

c71n93 commented Oct 24, 2023

c71n93 commented Oct 25, 2023

maxonfjvipon left a comment

maxonfjvipon Oct 25, 2023

c71n93 Oct 25, 2023

maxonfjvipon Oct 25, 2023

c71n93 Oct 25, 2023

maxonfjvipon left a comment

c71n93 commented Oct 26, 2023

maxonfjvipon Oct 26, 2023

c71n93 Oct 27, 2023

maxonfjvipon Oct 27, 2023

c71n93 Oct 27, 2023

maxonfjvipon left a comment

c71n93 commented Oct 27, 2023

yegor256 commented Oct 27, 2023

c71n93 commented Oct 27, 2023

yegor256 commented Oct 27, 2023

c71n93 commented Oct 27, 2023

yegor256 commented Oct 27, 2023

c71n93 commented Oct 27, 2023

yegor256 commented Oct 27, 2023

maxonfjvipon Oct 30, 2023

c71n93 Oct 30, 2023

maxonfjvipon Oct 30, 2023

c71n93 Oct 30, 2023

c71n93 commented Oct 30, 2023

maxonfjvipon left a comment

c71n93 commented Oct 30, 2023

yegor256 commented Oct 31, 2023

rultor commented Oct 31, 2023

rultor commented Oct 31, 2023

		- "eo-runtime/src/main/java/EOorg/EOeolang/EOfloat$EOeq.java"
		- "eo-runtime/src/main/java/EOorg/EOeolang/EOint$EOeq.java"

Made eq attribute of standard objects int and float to meet the standards (IEEE 754) #2554

Made eq attribute of standard objects int and float to meet the standards (IEEE 754) #2554

Conversation

c71n93 commented Oct 24, 2023 • edited by pr-codex bot Loading

PR-Codex overview

Focus of this PR:

Detailed summary:

c71n93 commented Oct 24, 2023

c71n93 commented Oct 25, 2023

maxonfjvipon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maxonfjvipon left a comment

Choose a reason for hiding this comment

c71n93 commented Oct 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maxonfjvipon left a comment

Choose a reason for hiding this comment

c71n93 commented Oct 27, 2023

yegor256 commented Oct 27, 2023

c71n93 commented Oct 27, 2023

yegor256 commented Oct 27, 2023

c71n93 commented Oct 27, 2023

yegor256 commented Oct 27, 2023

c71n93 commented Oct 27, 2023

yegor256 commented Oct 27, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

c71n93 commented Oct 30, 2023

maxonfjvipon left a comment

Choose a reason for hiding this comment

c71n93 commented Oct 30, 2023

yegor256 commented Oct 31, 2023

rultor commented Oct 31, 2023

rultor commented Oct 31, 2023

Made eq attribute of standard objects `int` and `float` to meet the standards (IEEE 754) #2554

Made eq attribute of standard objects `int` and `float` to meet the standards (IEEE 754) #2554

c71n93 commented Oct 24, 2023 •

edited by pr-codex bot

Loading