Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linting #335

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Fix linting #335

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7c5f3c9
Move Gemfile to top level so we can use CocoaPods linting and trunk p…
ZevEisenberg Dec 2, 2020
851473c
Stop running bundle install in lint script.
ZevEisenberg Dec 4, 2020
5a53d71
Bundle install from root, pod install from Examples.
ZevEisenberg Dec 4, 2020
3a7a5a5
set bundler path locally, not globally
mr-fixit Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,6 @@ ocunit.xml
*.xcbkptlist
*.xcsettings

Examples/vendor/bundle/
vendor/bundle/
.bundle/
Pods/
0 Examples/Gemfile → Gemfile
View file
Open in desktop
File renamed without changes.
0 Examples/Gemfile.lock → Gemfile.lock
View file
Open in desktop
File renamed without changes.
20 changes: 17 additions & 3 deletions scripts/lint
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,26 @@
#!/usr/bin/env sh

set -eu
set -o pipefail

printf 'linting CocoaPods\n'

if ! command -v bundle > /dev/null; then
printf 'bundler is not installed.\n'
printf 'install with $ gem install bundler\n'
exit 1
fi

bundle config set path 'vendor/bundle'
bundle install
ZevEisenberg marked this conversation as resolved.
Show resolved Hide resolved
bundle exec pod lib lint

printf 'linting Carthage\n'

if ! command -v carthage > /dev/null; then
printf 'Carthage is not installed.\n'
printf 'See https://github.com/Carthage/Carthage for install instructions.\n'
exit 1
fi


carthage build --platform iOS --no-use-binaries --no-skip-current
ZevEisenberg marked this conversation as resolved.
Show resolved Hide resolved

pod lib lint