Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linting #335

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Fix linting #335

wants to merge 4 commits into from

Conversation

ZevEisenberg
Copy link
Contributor

Some linting cleanup.

TODO:

  • Carthage lint isn't working right now. Need to figure out the correct way to get an Xcode project with a shared scheme that builds the library.

mr-fixit
mr-fixit reviewed Dec 2, 2020
View reviewed changes
scripts/lint Outdated Show resolved Hide resolved
scripts/lint Show resolved Hide resolved
@ZevEisenberg
Copy link
Contributor Author

ZevEisenberg commented Dec 2, 2020 •
edited
Loading

Thinking the CocoaPods template project is too opinionated and hard to control, and we can simplify the whole thing by making our own non-CocoaPods project. That's the direction I'll probably go in this PR. See https://GitHub.com/Rightpoint/BonMot for an example of how this might look.

@mr-fixit mr-fixit self-requested a review December 2, 2020 03:24
mr-fixit
mr-fixit approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@mr-fixit mr-fixit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but please also change this line in bootstrap

cd "$(dirname "$0")/../Examples"

@ZevEisenberg
Copy link
Contributor Author

I filed this bug with CocoaPods regarding the Carthage breakage. Going to work around it manually by making our own project file. https://github.com/CocoaPods/CocoaPods/issues/10266

@ZevEisenberg ZevEisenberg marked this pull request as draft December 4, 2020 19:56
mr-fixit
mr-fixit approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@mr-fixit mr-fixit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for pursuing this!

@ZevEisenberg
Copy link
Contributor Author

I filed a CocoaPods bug on something that's making this trickier, but I think we can still work around it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-fixit mr-fixit mr-fixit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZevEisenberg @mr-fixit