Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 39 #185

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix issue 39 #185

wants to merge 1 commit into from

Conversation

brianneisler
Copy link
Contributor

This commit fixes an issue where backgroundColor and tintColor values are not properly being reset after dismissal of view controller. This also adds DerivedData to .gitignore to prevent local env from making its way in to github.

Fixes issue #39.

… being reset after dismissal of view controller. Fixes issue #39.
@bcapps
Copy link
Contributor

bcapps commented Apr 19, 2016

Ideally, it would be great if the transition animator could store and later reset the background color(s) to the correct values. Since the animator objects are fairly generic and are intended to potentially be used with any view controller, making all of the view controllers used with this animator have to know to set their background colors in viewWillAppear (which is not the norm) seems like a less than desirable API, in my mind. Curious what @cdzombak thinks, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants