reset the dismissing view's backgroundColor's alpha to 1.0 after pan-to-dismiss #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dismissing a photos vc, the dismissal interaction sets the background alpha to 0.0, so if you have a photo viewer cached, and want to present it multiple times, the background alpha will be set to 0.0 on the second, third, …th presentation.
(to reproduce:
NYTPhotosViewControllerpropertythe background of the photos vc is missing after it finishes presenting due to step 4)
I'm not positive if this is the best way to fix the bug -- someone could have a background color with an alpha of something other than 1.0 set, but there's existing code in the same method that also seems to assume we're targeting an alpha of 1.0, so, this seemed like a safe place to start the discussion.