fix: various failures and issues

[stevenh]

Refactor tests to be more reliable, making them independent of each other, so if one test fails others are not effected. This includes self managing timeouts as mocha doesn't handle pending promises, which makes it harder to debug issues.

Run and Debug commands:

• Fix path to workspace files of "Language Server E2E Test" Run and Debug command.
• Rename to make it clear what each config is used for.

Add mochaExplorer configuration, to improve test visibility.

Re-enable big groovy test file, now it works as expected.

Rename test files to eliminate stuttering.

Fix test debugging by using NPM_DEBUG instead of DEBUG env var which is filtered out by vscode, see: microsoft/vscode#197494.

Remove duplicate lint call that's now handled by onDidChangeContent.

Remove fixed delay comment so we don't have to update when the delay changes.

Update Node and JVM versions in README.md.

Update all packages, to address security issues and bring in the latest version of npm-groovy-lint which includes a critical race condition fix.

Clean up imports.

Use onDidChangeContent to trigger re-linting to improve performance and remove skipNextOnDidChangeContents which
conflicts with this change.

Eliminate else statements where previous block returns, to improve code readability.

Refactor resetDiagnostics into deleteDiagnostics as its nowonly used for the delete flow, so we can remove unnecessary
logic and diagnostic changes.

Remove commented out code.

Convert high noise debugging to trace.

Add missing await to docManager.updateDocumentSettings call

Use latest xvfb-action@v1 instead of v1.0 to bring in the latest fixes.

Fixes #177 #174 #181 #172

Readiness Checklist

Author/Contributor

• Add entry to the CHANGELOG.md listing the change and linking to the corresponding issue (if appropriate)
• If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

• Label as breaking if this is a large fundamental change
• Label as either automation, bug, documentation, enhancement, infrastructure, or performance

[nvuillam]

It smells masterclass here ❤️

[nvuillam]

@stevenh it's like you deep dived in my mind in the past, understood everything and made it more elegant, that's amazing, can't wait to see this PR merged and build a new golden statue :)

[nvuillam]

I see the test cases... they seem to have long execution time, maybe CodeNarc Server is not called and npm-groovy-lint fallbacks to new java command line ? :/

[stevenh]

I see the test cases... they seem to have long execution time, maybe CodeNarc Server is not called and npm-groovy-lint fallbacks to new java command line ? :/

There's definitely some slowness, focusing in on stability for now.

[stevenh]

Looks like there is still a race deep in the code, it's not clear if its vscode extension, npm-groovy-lint or both, but still more work to do.

[stevenh]

Main race is fixed by nvuillam/npm-groovy-lint#343

[stevenh]

@nvuillam apologies for another huge set of changes, but wanted to get to a place where the tests were solid, which has taken quite a refactor.

I think we're finally there now, which should give us a solid base to move forward.

Please pay particular attention to the logic changes in the server component when reviewing, as there could be some reason for the original flow which I didn't understand.

[nvuillam]

@stevenh the original flow was to cancel the current linting request when there is a new one incoming for the same file ^^ ( lint while wiring code)

Is such feature still handled ? :)

[nvuillam]

Amazing work :)
I cloned your branch locally and made a few successful tests :)
Time for a new golden statue :)

[stevenh]

@stevenh the original flow was to cancel the current linting request when there is a new one incoming for the same file ^^ ( lint while wiring code)

Is such feature still handled ? :)

Thanks for that context, yes that case should still be handled 😀

[nvuillam]

@stevenh by the way... sorry, I used Canva.com again 🤣