-
-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: various failures and issues (#185)
* fix: Analyze Groovy files in folder Fix Analyze Groovy files in folder which was always available resulting in failures dependent on the context it was used. It is now only available from a explorer folder. Also correct the name of the parameter passed so explorer folder requests work. Fixes #177 * fix: partial fixes never applying Fix fixes in files which still have remaining issues not applying due to the change in behaviour of npm-groovy-lint status code handling in 11.0.0 by now requesting failon: none. * chore: improve debugging Add more debugging so that its easier to understand what is happening. Default debugging setting to that the DEBUG environment if set so that the developer doesn't have to set it manually in settings when running a debug session. Also enable npm-groovy-lint debugging which is key to understanding issues. While this was previous set for debugging sessions in the environment the setting would always override it. * ci: fix linting and update modules Fix all the CI linting errors and update modules to address vulnerabilities. * chore: update client and server dependencies Update all client and server dependencies to eliminate security issues. * fix: random test failures Refactor tests to be more reliable, making them independent of each other, so if one test fails others are not effected. This includes self managing timeouts as mocha doesn't handle pending promises, which makes it harder to debug issues. Run and Debug commands: * Fix path to workspace files of "Language Server E2E Test" Run and Debug command. * Rename to make it clear what each config is used for. Add mochaExplorer configuration, to improve test visibility. Re-enable big groovy test file, now it works as expected. Rename test files to eliminate stuttering. Fix test debugging by using NPM_DEBUG instead of DEBUG env var which is filtered out by vscode, see: microsoft/vscode#197494. Remove duplicate lint call that's now handled by onDidChangeContent. Remove fixed delay comment so we don't have to update when the delay changes. Update Node and JVM versions in README.md. Update all packages, to address security issues and bring in the latest version of npm-groovy-lint which includes a critical race condition fix. Clean up imports. Use onDidChangeContent to trigger re-linting to improve performance and remove skipNextOnDidChangeContents which conflicts with this change. Eliminate else statements where previous block returns, to improve code readability. Refactor resetDiagnostics into deleteDiagnostics as its now only used for the delete flow, so we can remove unnecessary logic and diagnostic changes. Remove commented out code. Convert high noise debugging to trace. Add missing await to docManager.updateDocumentSettings call Use latest xvfb-action@v1 instead of v1.0 to bring in the latest fixes.
- Loading branch information
Showing
41 changed files
with
7,232 additions
and
7,591 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| name: Update check | ||
|
|
||
| on: | ||
| push: | ||
| tags: | ||
| - v* | ||
| branches: | ||
| - main | ||
| pull_request: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| go: | ||
| name: Check for changes | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 18 | ||
|
|
||
| - name: Install dependencies and link | ||
| run: | | ||
| npm ci | ||
| npm link | ||
| - name: Validate no changes | ||
| run: | | ||
| npm run dev:pre-commit | ||
| git --no-pager diff | ||
| [[ 0 -eq $(git status --porcelain | wc -l) ]] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,42 +2,37 @@ name: Test | |
|
|
||
| on: [push, pull_request] | ||
|
|
||
| permissions: read-all | ||
|
|
||
| concurrency: | ||
| group: ${{ github.ref_name }}-${{ github.workflow }} | ||
| cancel-in-progress: false | ||
|
|
||
| jobs: | ||
| test_ubuntu: | ||
| name: Test Linux | ||
| runs-on: ubuntu-latest | ||
| test: | ||
| strategy: | ||
| matrix: | ||
| node_version: ['18'] | ||
| os: [ubuntu-latest, macos-latest, windows-latest] | ||
| name: Test | ||
| runs-on: ${{ matrix.os }} | ||
| timeout-minutes: 15 | ||
| steps: | ||
| - name: Checkout | ||
| - name: Checkout Code | ||
| uses: actions/checkout@v3 | ||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v2 | ||
| - name: Install node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: "14" | ||
| node-version: ${{ matrix.node_version }} | ||
| - name: Install dependencies | ||
| run: npm install | ||
| - name: Lint | ||
| run: npm run lint | ||
| - name: Compile | ||
| run: npm run compile | ||
| - name: Run headless test | ||
| uses: GabrielBB/[email protected] | ||
| uses: GabrielBB/xvfb-action@v1 | ||
| env: | ||
| NPM_DEBUG: vscode-groovy-lint | ||
| with: | ||
| run: npm run test | ||
| test_windows: | ||
| name: Test Windows | ||
| runs-on: windows-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: "14" | ||
| - name: Install dependencies | ||
| run: npm install | ||
| - name: Lint | ||
| run: npm run lint | ||
| - name: Compile | ||
| run: npm run compile | ||
| - name: Run tests | ||
| run: npm run test | ||
Oops, something went wrong.