Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernization and Permission Handling #16

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Modernization and Permission Handling #16

wants to merge 28 commits into from

Commits on Jan 5, 2021

  1. Apply project changes recommended by Xcode 12.3.

    Jan Weiß committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    d1123cc View commit details
    Browse the repository at this point in the history

  2. Improve gitignore.

    Jan Weiß committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    2c7ad32 View commit details
    Browse the repository at this point in the history

  3. Added unversioned TeamID infrastructure. 

    This is described in detail in the file "Shared.xcconfig".
Please make sure CODE_SIGN_IDENTITY keys for the Xcode project or config files are not committed to git.
    Jan Weiß committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    786315c View commit details
    Browse the repository at this point in the history

  4. Set 'ALWAYS_SEARCH_USER_PATHS' to NO. 

    This removes the warning regarding the setting.
    Jan Weiß committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    b09dcda View commit details
    Browse the repository at this point in the history

  5. Enable automatic code signing.

    Jan Weiß committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    ffabf67 View commit details
    Browse the repository at this point in the history

  6. Enable app sandboxing.

    Jan Weiß committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    30261d7 View commit details
    Browse the repository at this point in the history

  7. Enable hardened runtime.

    Jan Weiß committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    5d11491 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. Trailing whitespace removed by Xcode source formatter.

    Jan Weiß committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    b3c486c View commit details
    Browse the repository at this point in the history

  2. Convert to ARC.

    Jan Weiß committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    e75a4bc View commit details
    Browse the repository at this point in the history

  3. Fix memory issues found by static analyzer.

    Jan Weiß committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    9edef44 View commit details
    Browse the repository at this point in the history

  4. Fix localization issues found by static analyzer.

    Jan Weiß committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    73d5a4c View commit details
    Browse the repository at this point in the history

  5. Fix issue found by static analyzer: value stored to 'blue' is never r… 

    …ead.
    Jan Weiß committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    050734c View commit details
    Browse the repository at this point in the history

  6. Set project to default to use tabs for indentation as most of the cod… 

    …e uses that.

At some point, all code should be reformatted to use tabs.
    Jan Weiß committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    297e593 View commit details
    Browse the repository at this point in the history

  7. Convert NIB to XIB.

    Jan Weiß committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    fd42bd4 View commit details
    Browse the repository at this point in the history

  8. XIB touched by Xcode.

    Jan Weiß committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    b044704 View commit details
    Browse the repository at this point in the history

  9. Fix autolayout issues in XIB.

    Jan Weiß committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    dab8bf3 View commit details
    Browse the repository at this point in the history

  10. Fix font.

    Jan Weiß committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    b19d787 View commit details
    Browse the repository at this point in the history

  11. Add screen recordings permission checking and dialog UI.

    Jan Weiß committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    ef577a7 View commit details
    Browse the repository at this point in the history

  12. Add “Development” section to RADME.

    Jan Weiß committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    eefca34 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. Sandbox permission to write files

    @berniejenny
    berniejenny committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    8b0868c View commit details
    Browse the repository at this point in the history

  2. Screen recording dialog tweaks 

    Removed background color from text fields. More compact description of required permission.
    @berniejenny
    berniejenny committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    6b3d25d View commit details
    Browse the repository at this point in the history

  3. Increased version to 1.3.1 

    Mentioning JanX2 in About dialog.
    @berniejenny
    berniejenny committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    b324cb4 View commit details
    Browse the repository at this point in the history

  4. Permission dialog shown when simulation is selected 

    The permission dialog is now shown each time the user selects a simulation menu item and capturing the screen is not possible. This avoids overlapping welcome and permission dialogs, and also reminds the user what to do in case they close the permission dialog.
    @berniejenny
    berniejenny committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    014a14f View commit details
    Browse the repository at this point in the history

  5. Conditionally disable simulation menu items 

    Only enable menu items for simulating color impaired vision when capturing the screen is possible or the permission dialog is not currently visible.
    @berniejenny
    berniejenny committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    d766a9c View commit details
    Browse the repository at this point in the history

  6. Permission dialog is no longer released when closed.

    @berniejenny
    berniejenny committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    ef8b2c2 View commit details
    Browse the repository at this point in the history

  7. Partially revert "Screen recording dialog tweaks" 

    This partially reverts commit 6b3d25d.
    Jan Weiß committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    e490bc1 View commit details
    Browse the repository at this point in the history

  8. Tweak XIB layout. 

    Remove window buttons from top-left of permission panel window. Now it fully behaves like a dialog panel.
    Jan Weiß committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    97decbe View commit details
    Browse the repository at this point in the history

  9. Reword permission dialog.

    Jan Weiß committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    97dfa16 View commit details
    Browse the repository at this point in the history