Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernization and Permission Handling #16

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Conversation

JanX2
Copy link

@JanX2 JanX2 commented Jan 6, 2021

Please have a look. I hope I haven’t missed anything. :)

As a sidenote: the graphics need updating. High-res icon (1024x1024) and retina support…

@nvkelso
Copy link
Owner

nvkelso commented Jan 6, 2021

@berniejenny can you take a look, please?

@nvkelso
Copy link
Owner

nvkelso commented Jan 6, 2021

I might have original icon art floating around on external drive...

Removed background color from text fields. More compact description of required permission.
Mentioning JanX2 in About dialog.
The permission dialog is now shown each time the user selects a simulation menu item and capturing the screen is not possible. This avoids overlapping welcome and permission dialogs, and also reminds the user what to do in case they close the permission dialog.
Only enable menu items for simulating color impaired vision when capturing the screen is possible or the permission dialog is not currently visible.
@berniejenny
Copy link
Collaborator

Thanks a lot, @JanX2! This is looking great! Please test my edits.

@JanX2
Copy link
Author

JanX2 commented Jan 7, 2021

Thank you for adding the missing entitlement!

I think the wording was more clear in the verbose version. Not everyone understands the details and explaining them helps in that case.

Will have a look at the other changes.

Jan Weiß added 3 commits January 7, 2021 11:53
Remove window buttons from top-left of permission panel window. Now it fully behaves like a dialog panel.
@JanX2
Copy link
Author

JanX2 commented Jan 7, 2021

6b3d25d broke some of the XIB. Should be fixed now.

Tested the other commits.

Moving to the Applications folder seems broken, but I’m pretty confident someone using such a dependency will have a close-to drop-in solution. I have enabled launch at log-in, but can’t restart at the moment.

I have spent as much time on this as I could. Would be grateful for help!

@JanX2
Copy link
Author

JanX2 commented Jan 8, 2021

Correction: My suspicion was wrong. Launch at login appears to be working fine here.

@djchi82
Copy link

djchi82 commented Mar 14, 2024

Any plans to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants