Prevent non mc from dutying more than 6 hours consecutively

app/assets/javascripts/duties.js

@@ -147,12 +147,13 @@ function validateModal() {
 }
 
 function validateGrabPage() {
-  if ($("#grab-page-form input[type=checkbox]:checked").length > 0) {
-    return true;
-  } else {
+  // make sure at least one checkbox is checked
+  if (!$("#grab-page-form input[type=checkbox]:checked").length > 0) {
     alert("Please select at least one time slot");
     return false;
-  }
+  } 
+
+  return true;
 }
 
 $(document).on('turbolinks:load', load);

app/controllers/duties_controller.rb

@@ -2,6 +2,7 @@
 
 # rubocop:disable Metrics/ClassLength
 class DutiesController < ApplicationController
+  MAX_HRS = 6
   load_and_authorize_resource only: [:export]
   def index
     @header_iter = generate_header_iter
@@ -100,9 +101,51 @@ def can_duty_mc_timeslots?(duty_ids)
     timeslots.all? { |t| !t.mc_only }
   end
 
+  # helper for non_mc_exceed_hrs
+  def grabable_timeslots(duty_ids)
+    # timeslots of duty to grab
+    timeslot_ids = Duty.where(id: duty_ids).pluck(:timeslot_id)
+    time_range_ids = Timeslot.find(timeslot_ids).pluck(:time_range_id)
+    TimeRange.find(time_range_ids)
+  end
+
+  # helper for non_mc_exceed_hrs
+  def user_timeslots(duty_ids)
+    # timeslots of user on the day
+    date = Duty.where(id: duty_ids).pluck(:date)
+    usr_timeslot_ids = Duty.where(date: date, user_id: current_user.id)
+                           .pluck(:timeslot_id)
+    usr_time_range_ids = Timeslot.find(usr_timeslot_ids).pluck(:time_range_id)
+    TimeRange.find(usr_time_range_ids)
+  end
+
+  def non_mc_exceed_hrs?(num_hrs, duty_ids)
+    return false if current_user.mc
+
+    all_time_ranges = grabable_timeslots(duty_ids) + user_timeslots(duty_ids)
+    all_time_ranges.sort! { |r1, r2| r1.start_time <=> r2.start_time }
+
+    prev_range = all_time_ranges[0]
+    total_hrs = (prev_range.end_time.to_i - prev_range.start_time.to_i) / 3600.0
+    (1...all_time_ranges.length).each do |i|
+      range = all_time_ranges[i]
+      if range.start_time.to_i == prev_range.end_time.to_i
+        total_hrs += (range.end_time.to_i - range.start_time.to_i) / 3600.0
+        return true if total_hrs > num_hrs
+      else
+        total_hrs = 0 # reset hour counter
+      end
+
+      prev_range = range
+    end
+
+    false
+  end
+
   def grabable?(duty_ids)
     return false if duty_ids.blank?
     return false unless can_duty_mc_timeslots?(duty_ids)
+    return false if non_mc_exceed_hrs?(MAX_HRS, duty_ids)
 
     grabable_duties.where(id: duty_ids).size == duty_ids.size
   end

app/views/duties/index.html.erb

@@ -1,6 +1,7 @@
 <div id="duty-start-time" data-start-time=<%= TimeRange.order(:start_time).first.start_time.strftime('%H') %>></div>
 <div id="duty-end-time" data-end-time=<%= TimeRange.order(:end_time).last.end_time.strftime('%H')%>></div>
 <div id="num-of-places" data-num-of-places=<%= @places.count %>></div>
+<div id="current-user" data-current-user=<%= current_user%>>
 
 <div class="container-fluid no-padding-top">
   <div class="row">

env

@@ -0,0 +1,3 @@
+MAILGUN_API_KEY=key-0123456789abcdef0123456789abcdef
+MAILGUN_DOMAIN=sandbox0123456789abcdef0123456789abcdef.mailgun.org
+MAILER_HOST=nussucommit.org

spec/controllers/duties_controller_spec.rb

@@ -58,7 +58,8 @@
 
   describe 'POST duties#grab' do
     before do
-      sign_in create(:user)
+      @user = create(:user)
+      sign_in @user
     end
 
     it 'grab a duty' do
@@ -136,6 +137,87 @@
       should redirect_to duties_path
       expect(flash[:alert]).to be('Invalid duties to grab')
     end
+
+    it 'does nothing when non-MC user tries to duty for more than 6 hours
+        consecutively' do
+      time_range1 = create(:time_range, start_time: Time.zone.now - 1.hour,
+                                        end_time: Time.zone.now + 2.hours)
+      timeslot1 = create(:timeslot, time_range: time_range1)
+      create(:duty, user: @user, timeslot: timeslot1)
+
+      time_range2 = create(:time_range, start_time: Time.zone.now + 4.hours,
+                                        end_time: Time.zone.now + 6.hours)
+      timeslot2 = create(:timeslot, time_range: time_range2)
+      create(:duty, user: @user, timeslot: timeslot2)
+
+      time_range3 = create(:time_range, start_time: Time.zone.now + 2.hours,
+                                        end_time: Time.zone.now + 4.hours)
+      timeslot3 = create(:timeslot, time_range: time_range3)
+      duty_to_grab = create(:duty, free: true, timeslot: timeslot3)
+
+      patch :grab, params: { duty_id: { duty_to_grab.id => duty_to_grab.id } }
+
+      should redirect_to duties_path
+      expect(flash[:alert]).to be('Invalid duties to grab')
+    end
+
+    it 'grabs duty when non-MC user tries to duty for exactly 6 hours
+        consecutively' do
+      time_range1 = create(:time_range, start_time: Time.zone.now - 1.hour,
+                                        end_time: Time.zone.now + 2.hours)
+      timeslot1 = create(:timeslot, time_range: time_range1)
+      create(:duty, user: @user, timeslot: timeslot1)
+
+      time_range2 = create(:time_range, start_time: Time.zone.now + 4.hours,
+                                        end_time: Time.zone.now + 5.hours)
+      timeslot2 = create(:timeslot, time_range: time_range2)
+      create(:duty, user: @user, timeslot: timeslot2)
+
+      time_range3 = create(:time_range, start_time: Time.zone.now + 2.hours,
+                                        end_time: Time.zone.now + 4.hours)
+      timeslot3 = create(:timeslot, time_range: time_range3)
+      duty_to_grab = create(:duty, free: true, timeslot: timeslot3)
+
+      start_date = duty_to_grab.date.beginning_of_week
+      expect do
+        patch :grab, params: { duty_id: { duty_to_grab.id => duty_to_grab.id } }
+        duty_to_grab.reload
+      end.to change { duty_to_grab.user }.to(subject.current_user)
+
+      expect(duty_to_grab.free).to be(false)
+      expect(duty_to_grab.request_user_id).to be(nil)
+      should redirect_to duties_path(start_date: start_date)
+      expect(flash[:notice]).to be('Duty successfully grabbed!')
+    end
+
+    it 'grabs duty when non-MC user tries to duty for more than 6 hours
+        non-consecutively' do
+      time_range1 = create(:time_range, start_time: Time.zone.now - 1.hour,
+                                        end_time: Time.zone.now + 2.hours)
+      timeslot1 = create(:timeslot, time_range: time_range1)
+      create(:duty, user: @user, timeslot: timeslot1)
+
+      time_range2 = create(:time_range, start_time: Time.zone.now + 5.hours,
+                                        end_time: Time.zone.now + 7.hours)
+      timeslot2 = create(:timeslot, time_range: time_range2)
+      create(:duty, user: @user, timeslot: timeslot2)
+
+      time_range3 = create(:time_range, start_time: Time.zone.now + 2.hours,
+                                        end_time: Time.zone.now + 4.hours)
+      timeslot3 = create(:timeslot, time_range: time_range3)
+      duty_to_grab = create(:duty, free: true, timeslot: timeslot3)
+
+      start_date = duty_to_grab.date.beginning_of_week
+      expect do
+        patch :grab, params: { duty_id: { duty_to_grab.id => duty_to_grab.id } }
+        duty_to_grab.reload
+      end.to change { duty_to_grab.user }.to(subject.current_user)
+
+      expect(duty_to_grab.free).to be(false)
+      expect(duty_to_grab.request_user_id).to be(nil)
+      should redirect_to duties_path(start_date: start_date)
+      expect(flash[:notice]).to be('Duty successfully grabbed!')
+    end
   end
 
   describe 'POST duties#drop' do