Prevent non mc from dutying more than 6 hours consecutively #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vely' of https://github.com/nussucommit/takoyaki into prevent-non-mc-from-dutying-more-than-6-hours-consecutively
…vely' of https://github.com/nussucommit/takoyaki into prevent-non-mc-from-dutying-more-than-6-hours-consecutively
…vely' of https://github.com/nussucommit/takoyaki into prevent-non-mc-from-dutying-more-than-6-hours-consecutively
…urs-consecutively
…vely' of https://github.com/nussucommit/takoyaki into prevent-non-mc-from-dutying-more-than-6-hours-consecutively
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
…vely' of https://github.com/nussucommit/takoyaki into prevent-non-mc-from-dutying-more-than-6-hours-consecutively
…vely' of https://github.com/nussucommit/takoyaki into prevent-non-mc-from-dutying-more-than-6-hours-consecutively
…vely' of https://github.com/nussucommit/takoyaki into prevent-non-mc-from-dutying-more-than-6-hours-consecutively
…vely' of https://github.com/nussucommit/takoyaki into prevent-non-mc-from-dutying-more-than-6-hours-consecutively
…vely' of https://github.com/nussucommit/takoyaki into prevent-non-mc-from-dutying-more-than-6-hours-consecutively
…vely' of https://github.com/nussucommit/takoyaki into prevent-non-mc-from-dutying-more-than-6-hours-consecutively
…urs-consecutively
ryoarmanda
reviewed
Apr 11, 2020
Comment on lines
+1
to
+3
| MAILGUN_API_KEY=key-0123456789abcdef0123456789abcdef | ||
| MAILGUN_DOMAIN=sandbox0123456789abcdef0123456789abcdef.mailgun.org | ||
| MAILER_HOST=nussucommit.org |
There was a problem hiding this comment.
Don't include this file in the branch. (Btw, the filename is supposed to be .env, you're missing a dot)
| all_time_ranges.sort! { |r1, r2| r1.start_time <=> r2.start_time } | ||
| end | ||
|
|
||
| def non_mc_exceed_hrs?(num_hrs, duty_ids) |
There was a problem hiding this comment.
Metrics/AbcSize: Assignment Branch Condition size for non_mc_exceed_hrs? is too high. [26.42/18]
ryoarmanda
reviewed
Apr 11, 2020
app/views/duties/index.html.erb
Outdated
| @@ -1,6 +1,7 @@ | |||
| <div id="duty-start-time" data-start-time=<%= TimeRange.order(:start_time).first.start_time.strftime('%H') %>></div> | |||
| <div id="duty-end-time" data-end-time=<%= TimeRange.order(:end_time).last.end_time.strftime('%H')%>></div> | |||
| <div id="num-of-places" data-num-of-places=<%= @places.count %>></div> | |||
| <div id="current-user" data-current-user=<%= current_user%>> | |||
…vely' of https://github.com/nussucommit/takoyaki into prevent-non-mc-from-dutying-more-than-6-hours-consecutively
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created function `non_mc_exceed_hrs?' to check if non mc user duty for more than 6 hours after grabbing duty and implemented three test cases to check correctness
Ryo's edit: Resolves #300