samples: bluetooth: absolute pin number in conn_time_sync and iso_time_sync #17639
+8
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
yuxCai
force-pushed
the
conn_time_sync_fix_for_54l15
branch
from
244c035
to
2eb9cc5
Compare
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 006014ee92a94b7d2742133c8dac575777c61cd0 more detailssdk-nrf:
Github labels
List of changed files detected by CI (2)Outputs:ToolchainVersion: 9583beca34 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
Do we have the same issue in the iso_time_sync sample? |
yuxCai
force-pushed
the
conn_time_sync_fix_for_54l15
branch
from
2eb9cc5
to
a8e7283
Compare
Had a quick look and it seems like it. Do you know if it is failing the CI somehow or the sample is not run at all? |
yuxCai
force-pushed
the
conn_time_sync_fix_for_54l15
branch
from
a8e7283
to
9146221
Compare
yuxCai
changed the title
Tschet1
reviewed
Oct 4, 2024
| @@ -30,6 +30,15 @@ static struct gpio_dt_spec led = GPIO_DT_SPEC_GET_OR(DT_ALIAS(led1), gpios, {0}) | |||
|
|
|||
| static uint8_t previous_led_value; | |||
|
|
|||
| struct gpio_nrfx_cfg { | |||
There was a problem hiding this comment.
Discussed offline:
we should not mirror this type here. Instead, the required functionality could be added to the zephyr driver.
yuxCai
force-pushed
the
conn_time_sync_fix_for_54l15
branch
from
9146221
to
35a06d7
Compare
…e_sync The two samples failed on 54l15 because they were not using the absolute pin number for LED1. Signed-off-by: Yuxuan Cai <[email protected]>
yuxCai
force-pushed
the
conn_time_sync_fix_for_54l15
branch
from
35a06d7
to
006014e
Compare
rugeGerritsen
approved these changes
Oct 4, 2024
Tschet1
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample could not run on 54l15 because the pin number was not converted to the absolute value.