Samples: Bluetooth: ISO time sync fixes #17646
Open
+23
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
doc-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 1ebb4c84aab369654e52229c3bf858b7c3342b39 more detailssdk-nrf:
Github labels
List of changed files detected by CI (4)Outputs:ToolchainVersion: 9583beca34 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
ludvigsj
force-pushed
the
develop/NCSDK-29302_ISO_time_sync_fixes
branch
from
71b6e56
to
becb41e
Compare
This commit fixes the following:
* Fix a bug in the initialization of `init_val` in the GPIOTE task
used for the LED, where it would always be initialized to
`NRF_GPIOTE_INITIAL_VALUE_HIGH` and not take the dt_flags into
account. This made the LED toggle with inverted polarity on
platforms where the LEDs are active high.
* Change the LED used when
`CONFIG_LED_TOGGLE_IMMEDIATELY_ON_SEND_OR_RECEIVE` is enabled to not
conflict with the LED used to display synchronized toggling.
* Update references to LED numbers in the README to match the actual
sample behavior.
Signed-off-by: Ludvig Jordet <[email protected]>
ludvigsj
force-pushed
the
develop/NCSDK-29302_ISO_time_sync_fixes
branch
from
becb41e
to
1ebb4c8
Compare
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the following:
Sample now uses absolute pin for GPIOTE, to make the LED work on platforms where the LEDs are not on port 0 (such as nRF54L15).init_valin the GPIOTE task used for the LED, where it would always be initialized toNRF_GPIOTE_INITIAL_VALUE_HIGHand not take the dt_flags into account. This made the LED toggle with inverted polarity on platforms where the LEDs are active high.CONFIG_LED_TOGGLE_IMMEDIATELY_ON_SEND_OR_RECEIVEis enabled to not conflict with the LED used to display synchronized toggling.