lib: modem_info: Update RSRP/RSRQ calculation #17528
Open
+88
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 7cc1f485b25ac2d14bc71c62b699b06f508ae1e6 more detailssdk-nrf:
Github labels
List of changed files detected by CI (4)Outputs:ToolchainVersion: 9583beca34 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
tokangas
reviewed
Oct 2, 2024
trantanen
force-pushed
the
lte_lc_rsrp_doc
branch
from
93ff726
to
39af812
Compare
github-actions
bot
added
doc-required
trantanen
commented
Oct 3, 2024
peknis
requested changes
Oct 3, 2024
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
trantanen
force-pushed
the
lte_lc_rsrp_doc
branch
3 times, most recently
from
ecd3661
to
d7ab7d4
Compare
trantanen
force-pushed
the
lte_lc_rsrp_doc
branch
from
d7ab7d4
to
0db6641
Compare
tokangas
reviewed
Oct 4, 2024
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
| * command reference guide for more information. | ||
| /** @brief Converts RSRP index value returned by the modem to dBm. | ||
| * | ||
| * The index value of RSRP can be converted to decibel with the following formula: |
There was a problem hiding this comment.
This should be dBm instead, but should it be plural, @peknis?
Suggested change
| * The index value of RSRP can be converted to decibel with the following formula: | |
| * The index value of RSRP can be converted to dBm with the following formula: |
There was a problem hiding this comment.
This is copy paste from AT command spec and I did send the question to Jaakko earlier
|
|
||
| /** @brief Converts RSRQ index value returned by the modem to dB. | ||
| * | ||
| * The index value of RSRQ can be converted to decibel with the following formula: |
There was a problem hiding this comment.
Should "decibel" be plural or not, @peknis?
There was a problem hiding this comment.
Waiting for Jaakko's feedback
AT Command Reference Guide has been updated based on how the modem behaves. Doing corresponding update to app side. Jira: TNSW-62531 Signed-off-by: Tommi Rantanen <[email protected]>
AT Command Reference Guide has been updated based on how the modem behaves. Doing corresponding update to app side. Jira: TNSW-62531 Signed-off-by: Tommi Rantanen <[email protected]>
trantanen
force-pushed
the
lte_lc_rsrp_doc
branch
from
606d0ff
to
7cc1f48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AT Command Reference Guide has been updated based on how the modem behaves. Doing corresponding update to app side, i.e., modem_info and lte_link_control.
Jira: TNSW-62531