Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Tommi Kangas <[email protected]>
  • Loading branch information
trantanen and tokangas authored Oct 4, 2024
1 parent 0db6641 commit 606d0ff
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -761,7 +761,7 @@ Modem libraries
The formulas are now aligned with the modem implementation that has not changed
but the AT command reference guide has not been up to date with the modem implementation.

* Removed ``RSRP_OFFSET_VAL`` and ``RSRQ_OFFSET_VAL`` from the API.
* Removed ``RSRP_OFFSET_VAL``, ``RSRQ_OFFSET_VAL`` and ``RSRQ_SCALE_VAL`` from the API.
Clients should have used the :c:macro:`RSRP_IDX_TO_DBM` and the :c:macro:`RSRQ_IDX_TO_DB` macros.

* :ref:`nrf_modem_lib_lte_net_if` library:
Expand Down
14 changes: 7 additions & 7 deletions include/modem/modem_info.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ extern "C" {
/** @brief Converts RSRP index value returned by the modem to dBm.
*
* The index value of RSRP can be converted to decibel with the following formula:
* * Index < 0: Index – 140
* * Index = 0: Not used
* * Index > 0: Index – 141
* * index < 0: index – 140
* * index = 0: Not used
* * index > 0: index – 141
*
* Example values:
* * -17: RSRP < -156 dBm
Expand All @@ -79,10 +79,10 @@ extern "C" {
/** @brief Converts RSRQ index value returned by the modem to dB.
*
* The index value of RSRQ can be converted to decibel with the following formula:
* * Index < 0: (Index – 39) / 2
* * Index = 0: Not used
* * Index > 0 and index < 35: (Index – 40) / 2
* * Index ≥ 35: (Index – 41) / 2
* * index < 0: (index – 39) / 2
* * index = 0: Not used
* * index > 0 and index < 35: (index – 40) / 2
* * index ≥ 35: (index – 41) / 2
*
* Example values:
* * -30: RSRQ < -34.5 dB
Expand Down

0 comments on commit 606d0ff

Please sign in to comment.