Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applications: nrf_desktop/machine_learning: Align CONFIG_RESET_ON_FATAL_ERROR in child image configs #13378

Merged
merged 2 commits into from
Jan 12, 2024
Merged

applications: nrf_desktop/machine_learning: Align CONFIG_RESET_ON_FATAL_ERROR in child image configs #13378

merged 2 commits into from
Jan 12, 2024

Conversation

mkapala-nordic
Copy link
Contributor

Jira: NCSDK-22426

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 8, 2023
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 8, 2023 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
desktop52_verification X
test-fw-nrfconnect-apps X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

kapi-no
kapi-no reviewed Dec 8, 2023
View reviewed changes
Copy link
Contributor

@kapi-no kapi-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog entries

@mkapala-nordic mkapala-nordic force-pushed the align_reset_on_fatal_error_mcuboot_cfgs branch from b498c1a to 9fb5f08 Compare December 8, 2023 15:34
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Dec 8, 2023
@mkapala-nordic mkapala-nordic force-pushed the align_reset_on_fatal_error_mcuboot_cfgs branch from 9fb5f08 to 88924d7 Compare December 18, 2023 14:03
@mkapala-nordic
Copy link
Contributor Author

Only rebased

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@mkapala-nordic mkapala-nordic force-pushed the align_reset_on_fatal_error_mcuboot_cfgs branch from 88924d7 to 014ff81 Compare December 18, 2023 15:11
@mkapala-nordic mkapala-nordic force-pushed the align_reset_on_fatal_error_mcuboot_cfgs branch from 014ff81 to ae05ef8 Compare December 19, 2023 12:42
@mkapala-nordic mkapala-nordic changed the title applications: nrf_desktop/machine_learning: Align CONFIG_RESET_ON_FATAL_ERROR in MCUboot configs applications: nrf_desktop/machine_learning: Align CONFIG_RESET_ON_FATAL_ERROR in child image configs Dec 19, 2023
@mkapala-nordic mkapala-nordic force-pushed the align_reset_on_fatal_error_mcuboot_cfgs branch from ae05ef8 to 20e8adb Compare December 20, 2023 08:12
@mkapala-nordic
Copy link
Contributor Author

Applied @annwoj suggestions

@mkapala-nordic mkapala-nordic force-pushed the align_reset_on_fatal_error_mcuboot_cfgs branch from 20e8adb to 67f6111 Compare December 20, 2023 08:13
@mkapala-nordic
Copy link
Contributor Author

Rebased

@mkapala-nordic mkapala-nordic force-pushed the align_reset_on_fatal_error_mcuboot_cfgs branch from 67f6111 to 58e615f Compare January 2, 2024 08:40
@mkapala-nordic
Copy link
Contributor Author

Rebased

@mkapala-nordic mkapala-nordic force-pushed the align_reset_on_fatal_error_mcuboot_cfgs branch 3 times, most recently from 044e722 to dc647a1 Compare January 11, 2024 07:58
@mkapala-nordic
applications: machine_learning: Align reset on fatal err in child imgs
1773087 
Disable CONFIG_RESET_ON_FATAL_ERROR in MCUboot and hci_rpmsg child image
debug configurations in Machine Learning app and mark it as a debugging
feature.
Explicitly enable this option in the release configurations.

Jira: NCSDK-22426

Signed-off-by: Mateusz Kapala <[email protected]>
@mkapala-nordic
applications: nrf_desktop: Align reset on fatal in child imgs
9e51401 
Disable CONFIG_RESET_ON_FATAL_ERROR in MCUboot, B0 and hci_rpmsg debug
configurations in the nRF Desktop app and mark itas a debugging feature.
Explicitly enable this option in the release configurations.

Jira: NCSDK-22426

Signed-off-by: Mateusz Kapala <[email protected]>
@mkapala-nordic mkapala-nordic force-pushed the align_reset_on_fatal_error_mcuboot_cfgs branch from dc647a1 to 9e51401 Compare January 11, 2024 12:37
@rlubos rlubos merged commit fe3d4e2 into nrfconnect:main Jan 12, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekPieta MarekPieta MarekPieta approved these changes

@zycz zycz zycz approved these changes

@annwoj annwoj annwoj approved these changes

@alstrzebonski alstrzebonski Awaiting requested review from alstrzebonski

@pdunaj pdunaj Awaiting requested review from pdunaj

@carlescufi carlescufi Awaiting requested review from carlescufi

@kapi-no kapi-no Awaiting requested review from kapi-no

@divipillai divipillai Awaiting requested review from divipillai

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mkapala-nordic @NordicBuilder @kapi-no @MarekPieta @zycz @annwoj @rlubos