Skip to content

Commit

Permalink
applications: nrf_desktop: Align reset on fatal in child imgs
Browse files Browse the repository at this point in the history
Disable CONFIG_RESET_ON_FATAL_ERROR in MCUboot, B0 and hci_rpmsg debug
configurations in the nRF Desktop app and mark itas a debugging feature.
Explicitly enable this option in the release configurations.

Jira: NCSDK-22426

Signed-off-by: Mateusz Kapala <[email protected]>
  • Loading branch information
mkapala-nordic authored and rlubos committed Jan 12, 2024
1 parent dc5016f commit fe3d4e2
Show file tree
Hide file tree
Showing 31 changed files with 94 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,6 @@ CONFIG_BOOT_SERIAL_IMG_GRP_HASH=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve firmware reliability
CONFIG_RESET_ON_FATAL_ERROR=y
Original file line number Diff line number Diff line change
Expand Up @@ -67,3 +67,6 @@ CONFIG_BOOT_SERIAL_IMG_GRP_HASH=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve firmware reliability
CONFIG_RESET_ON_FATAL_ERROR=y
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,6 @@ CONFIG_BOOT_BANNER=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve debugging experience by disabling reset on fatal error
CONFIG_RESET_ON_FATAL_ERROR=n
Original file line number Diff line number Diff line change
Expand Up @@ -61,3 +61,6 @@ CONFIG_BOOT_BANNER=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve firmware reliability
CONFIG_RESET_ON_FATAL_ERROR=y
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,6 @@ CONFIG_BOOT_BANNER=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve debugging experience by disabling reset on fatal error
CONFIG_RESET_ON_FATAL_ERROR=n
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,6 @@ CONFIG_BOOT_BANNER=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve firmware reliability
CONFIG_RESET_ON_FATAL_ERROR=y
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,6 @@ CONFIG_ASSERT=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve debugging experience by disabling reset on fatal error
CONFIG_RESET_ON_FATAL_ERROR=n
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,6 @@ CONFIG_ASSERT=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve debugging experience by disabling reset on fatal error
CONFIG_RESET_ON_FATAL_ERROR=n
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,6 @@ CONFIG_ASSERT=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve debugging experience by disabling reset on fatal error
CONFIG_RESET_ON_FATAL_ERROR=n
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,6 @@ CONFIG_ASSERT=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve firmware reliability
CONFIG_RESET_ON_FATAL_ERROR=y
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,6 @@ CONFIG_ASSERT=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve debugging experience by disabling reset on fatal error
CONFIG_RESET_ON_FATAL_ERROR=n
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,6 @@ CONFIG_NORDIC_QSPI_NOR=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve debugging experience by disabling reset on fatal error
CONFIG_RESET_ON_FATAL_ERROR=n
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,6 @@ CONFIG_BOOT_BANNER=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve debugging experience by disabling reset on fatal error
CONFIG_RESET_ON_FATAL_ERROR=n
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,6 @@ CONFIG_BOOT_BANNER=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve debugging experience by disabling reset on fatal error
CONFIG_RESET_ON_FATAL_ERROR=n
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,6 @@ CONFIG_BOARD_HAS_NRF5_BOOTLOADER=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve debugging experience by disabling reset on fatal error
CONFIG_RESET_ON_FATAL_ERROR=n
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,6 @@ CONFIG_BOARD_HAS_NRF5_BOOTLOADER=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve debugging experience by disabling reset on fatal error
CONFIG_RESET_ON_FATAL_ERROR=n
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,6 @@ CONFIG_BOARD_HAS_NRF5_BOOTLOADER=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve debugging experience by disabling reset on fatal error
CONFIG_RESET_ON_FATAL_ERROR=n
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,6 @@ CONFIG_BOARD_HAS_NRF5_BOOTLOADER=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve firmware reliability
CONFIG_RESET_ON_FATAL_ERROR=y
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,6 @@ CONFIG_BOARD_HAS_NRF5_BOOTLOADER=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve firmware reliability
CONFIG_RESET_ON_FATAL_ERROR=y
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,6 @@ CONFIG_ASSERT=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve debugging experience by disabling reset on fatal error
CONFIG_RESET_ON_FATAL_ERROR=n
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,6 @@ CONFIG_ASSERT=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve firmware reliability
CONFIG_RESET_ON_FATAL_ERROR=y
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,6 @@ CONFIG_BOOT_BANNER=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve debugging experience by disabling reset on fatal error
CONFIG_RESET_ON_FATAL_ERROR=n
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,13 @@ CONFIG_SERIAL=n
CONFIG_USE_SEGGER_RTT=n
CONFIG_ERRNO=n
CONFIG_PRINTK=n
CONFIG_RESET_ON_FATAL_ERROR=n
CONFIG_CBPRINTF_NANO=y
CONFIG_TIMESLICING=n
CONFIG_ARM_MPU=n
CONFIG_THREAD_STACK_INFO=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve debugging experience by disabling reset on fatal error
CONFIG_RESET_ON_FATAL_ERROR=n
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,6 @@ CONFIG_BOOT_BANNER=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve firmware reliability
CONFIG_RESET_ON_FATAL_ERROR=y
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,6 @@ CONFIG_ASSERT=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve firmware reliability
CONFIG_RESET_ON_FATAL_ERROR=y
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,6 @@ CONFIG_BOOT_BANNER=n

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve firmware reliability
CONFIG_RESET_ON_FATAL_ERROR=y
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,6 @@ CONFIG_MINIMAL_LIBC=y

# The anomaly 160 workaround is not needed for the bootloader.
CONFIG_SOC_NRF53_ANOMALY_160_WORKAROUND_NEEDED=n

# Improve debugging experience by disabling reset on fatal error
CONFIG_RESET_ON_FATAL_ERROR=n
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,6 @@ CONFIG_MINIMAL_LIBC=y

# The anomaly 160 workaround is not needed for the bootloader.
CONFIG_SOC_NRF53_ANOMALY_160_WORKAROUND_NEEDED=n

# Improve firmware reliability
CONFIG_RESET_ON_FATAL_ERROR=y
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,6 @@ CONFIG_EXCEPTION_STACK_TRACE=y

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve debugging experience by disabling reset on fatal error
CONFIG_RESET_ON_FATAL_ERROR=n
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,6 @@ CONFIG_BT_CTLR_SDC_MAX_CONN_EVENT_LEN_DEFAULT=3000

# Use minimal C library instead of the Picolib
CONFIG_MINIMAL_LIBC=y

# Improve firmware reliability
CONFIG_RESET_ON_FATAL_ERROR=y
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,10 @@ nRF Desktop
The ``CONFIG_USB_HID_BOOT_PROTOCOL`` Kconfig option was removed and dedicated API needs to be used instead.
* Disabled MCUboot's logs over RTT (:kconfig:option:`CONFIG_LOG_BACKEND_RTT` and :kconfig:option:`CONFIG_USE_SEGGER_RTT`) on ``nrf52840dk_nrf52840`` in :file:`prj_mcuboot_qspi.conf` configuration to reduce MCUboot memory footprint and avoid flash overflows.
Explicitly enabled the UART log backend (:kconfig:option:`CONFIG_LOG_BACKEND_UART`) together with its dependencies in the configuration file to ensure log visibility.
* The MCUboot, B0, and HCI RPMsg child images debug configurations to disable the :kconfig:option:`CONFIG_RESET_ON_FATAL_ERROR` Kconfig option.
Disabling this Kconfig option improves the debugging experience.
* The MCUboot, B0, and HCI RPMsg child images release configurations to explicitly enable the :kconfig:option:`CONFIG_RESET_ON_FATAL_ERROR` Kconfig option.
Enabling this Kconfig option improves the reliability of the firmware.

Thingy:53: Matter weather station
---------------------------------
Expand Down

0 comments on commit fe3d4e2

Please sign in to comment.