chore(dashboard): a few more fixes

apps/dashboard/src/components/workflow-editor/steps/configure-step-content.tsx

@@ -11,6 +11,7 @@ import { ConfigureInAppPreview } from './configure-in-app-preview';
 import { SdkBanner } from './sdk-banner';
 import { useStep } from './use-step';
 import { getFirstControlsErrorMessage, getFirstBodyErrorMessage } from '../step-utils';
+import { EXCLUDED_EDITOR_TYPES } from '@/utils/constants';
 
 export const ConfigureStepContent = () => {
   const { step } = useStep();
@@ -65,15 +66,19 @@ export const ConfigureStepContent = () => {
         <CommonFields />
       </SidebarContent>
       <Separator />
-      <SidebarContent>
-        <Link to={'./edit'} relative="path">
-          <Button variant="outline" className="flex w-full justify-start gap-1.5 text-xs font-medium" type="button">
-            <RiPencilRuler2Fill className="h-4 w-4 text-neutral-600" />
-            Configure {step?.type} template <RiArrowRightSLine className="ml-auto h-4 w-4 text-neutral-600" />
-          </Button>
-        </Link>
-      </SidebarContent>
-      <Separator />
+      {!EXCLUDED_EDITOR_TYPES.includes(step?.type ?? '') && (
+        <>
+          <SidebarContent>
+            <Link to={'./edit'} relative="path">
+              <Button variant="outline" className="flex w-full justify-start gap-1.5 text-xs font-medium" type="button">
+                <RiPencilRuler2Fill className="h-4 w-4 text-neutral-600" />
+                Configure {step?.type} template <RiArrowRightSLine className="ml-auto h-4 w-4 text-neutral-600" />
+              </Button>
+            </Link>
+          </SidebarContent>
+          <Separator />
+        </>
+      )}
       <SidebarContent>
         <SdkBanner />
       </SidebarContent>

apps/dashboard/src/components/workflow-editor/steps/edit-step-sidebar.tsx

@@ -1,4 +1,4 @@
-import { useMemo } from 'react';
+import { useEffect, useMemo } from 'react';
 import { motion } from 'framer-motion';
 import { useNavigate, useParams } from 'react-router-dom';
 
@@ -16,6 +16,7 @@ import { useFetchStep } from '@/hooks/use-fetch-step';
 import { VisuallyHidden } from '@/components/primitives/visually-hidden';
 import { PageMeta } from '@/components/page-meta';
 import { getStepBase62Id } from '@/utils/step';
+import { EXCLUDED_EDITOR_TYPES } from '@/utils/constants';
 
 const transitionSetting = { ease: [0.29, 0.83, 0.57, 0.99], duration: 0.4 };
 
@@ -34,9 +35,21 @@ export const EditStepSidebar = () => {
   );
 
   const handleCloseSidebar = () => {
-    navigate('../', { relative: 'path' });
+    navigate('..', { relative: 'path' });
   };
 
+  const isNotSupportedEditorType = EXCLUDED_EDITOR_TYPES.includes(stepType ?? '');
+
+  useEffect(() => {
+    if (isNotSupportedEditorType) {
+      navigate('..', { relative: 'path' });
+    }
+  }, [isNotSupportedEditorType, navigate]);
+
+  if (isNotSupportedEditorType) {
+    return null;
+  }
+
   return (
     <>
       <PageMeta title={`Edit ${step?.name}`} />

apps/dashboard/src/components/workflow-editor/steps/in-app/in-app-tabs.tsx

@@ -34,7 +34,7 @@ import {
   AlertDialogTitle,
 } from '@/components/primitives/alert-dialog';
 
-const tabsContentClassName = 'h-full w-full px-3 py-3.5';
+const tabsContentClassName = 'h-full w-full px-3 py-3.5 overflow-y-auto';
 
 export const InAppTabs = ({ workflow, step }: { workflow: WorkflowResponseDto; step: StepDataDto }) => {
   const { stepSlug = '', workflowSlug = '' } = useParams<{ workflowSlug: string; stepSlug: string }>();

apps/dashboard/src/components/workflow-editor/steps/other-steps-tabs.tsx

@@ -19,7 +19,7 @@ import { useUpdateWorkflow } from '@/hooks/use-update-workflow';
 import { buildDefaultValues, buildDynamicZodSchema } from '@/utils/schema';
 import { CustomStepControls } from './controls/custom-step-controls';
 
-const tabsContentClassName = 'h-full w-full px-3 py-3.5';
+const tabsContentClassName = 'h-full w-full px-3 py-3.5 overflow-y-auto';
 
 export const OtherStepTabs = ({ workflow, step }: { workflow: WorkflowResponseDto; step: StepDataDto }) => {
   const { stepSlug = '' } = useParams<{ workflowSlug: string; stepSlug: string }>();

apps/dashboard/src/utils/constants.ts

@@ -1,5 +1,14 @@
+import { StepTypeEnum } from '@novu/shared';
+
 export const AUTOCOMPLETE_PASSWORD_MANAGERS_OFF = {
   autoComplete: 'off',
   'data-1p-ignore': true,
   'data-form-type': 'other',
 };
+
+export const EXCLUDED_EDITOR_TYPES: string[] = [
+  StepTypeEnum.DIGEST,
+  StepTypeEnum.DELAY,
+  StepTypeEnum.TRIGGER,
+  StepTypeEnum.CUSTOM,
+];