chore(dashboard): a few more fixes #6985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LetItRock
requested review from
SokratisVidros,
BiswaViraj,
ChmaraX and
desiprisg
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LetItRock
commented
Nov 13, 2024
| </Link> | ||
| </SidebarContent> | ||
| <Separator /> | ||
| {!EXCLUDED_EDITOR_TYPES.includes(step?.type ?? '') && ( |
There was a problem hiding this comment.
do not show the Configure {channel} template button for the step types: digest, delay, custom, trigger
| @@ -34,9 +35,21 @@ export const EditStepSidebar = () => { | |||
| ); | |||
|
|
|||
| const handleCloseSidebar = () => { | |||
| navigate('../', { relative: 'path' }); | |||
| navigate('..', { relative: 'path' }); | |||
There was a problem hiding this comment.
removed / at the end of the URL
Comment on lines
+43
to
+51
| useEffect(() => { | ||
| if (isNotSupportedEditorType) { | ||
| navigate('..', { relative: 'path' }); | ||
| } | ||
| }, [isNotSupportedEditorType, navigate]); | ||
|
|
||
| if (isNotSupportedEditorType) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
if step type is not supported, we should not allow opening the editor
| @@ -34,7 +34,7 @@ import { | |||
| AlertDialogTitle, | |||
| } from '@/components/primitives/alert-dialog'; | |||
|
|
|||
| const tabsContentClassName = 'h-full w-full px-3 py-3.5'; | |||
| const tabsContentClassName = 'h-full w-full px-3 py-3.5 overflow-y-auto'; | |||
There was a problem hiding this comment.
scrollbar for the In-App Editor drawer content when there is not enough space
SokratisVidros
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
A few more small improvements.
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer