Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#413] The test coverage does NOT show the correct statistics #452

Merged
merged 1 commit into from
Aug 7, 2023
Merged

[#413] The test coverage does NOT show the correct statistics #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .template/addons/github/.github/workflows/test.yml.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:
run: docker-compose pull test || true

- name: Run codebase test
run: docker-compose run test bundle exec rspec spec/codebase/codebase_spec.rb --format progress
run: docker-compose run test -e DISABLE_SPRING=1 bundle exec rspec spec/codebase/codebase_spec.rb --format progress
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sanG-github we are facing an error due to this changes in our new project, could you double check that, we removed the -e DISABLE_SPRING=1 now in our new project, thank you

image


unit_tests:
name: Unit tests
Expand All @@ -98,7 +98,7 @@ jobs:
run: docker-compose pull test || true

- name: Run unit tests
run: docker-compose run test bundle exec rspec --exclude-pattern "spec/systems/**/*_spec.rb, spec/codebase/codebase_spec.rb" --profile --format progress
run: docker-compose run test -e DISABLE_SPRING=1 bundle exec rspec --exclude-pattern "spec/systems/**/*_spec.rb, spec/codebase/codebase_spec.rb" --profile --format progress

- name: Upload tests coverage artifact
uses: actions/upload-artifact@v3
Expand Down
4 changes: 3 additions & 1 deletion spec/rails_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
# frozen_string_literal: true

require 'spec_helper'
require 'support/simplecov'

ENV['RAILS_ENV'] ||= 'test'
require File.expand_path('../config/environment', __dir__)

require 'spec_helper'
require 'rspec/rails'
require 'json_matchers/rspec'
require 'pundit/rspec'
Expand Down