[#413] The test coverage does NOT show the correct statistics #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanG-github
requested review from
rosle,
andyduong1920,
bterone,
byhbt,
carryall,
hoangmirs,
longnd,
malparty and
tyrro
as code owners
tyrro
approved these changes
Aug 2, 2023
malparty
approved these changes
Aug 7, 2023
| @@ -74,7 +74,7 @@ jobs: | |||
| run: docker-compose pull test || true | |||
|
|
|||
| - name: Run codebase test | |||
| run: docker-compose run test bundle exec rspec spec/codebase/codebase_spec.rb --format progress | |||
| run: docker-compose run test -e DISABLE_SPRING=1 bundle exec rspec spec/codebase/codebase_spec.rb --format progress | |||
There was a problem hiding this comment.
Hi @sanG-github we are facing an error due to this changes in our new project, could you double check that, we removed the -e DISABLE_SPRING=1 now in our new project, thank you
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #413
What happened 👀
Resolved the issue related to the code coverage always showing 0.00%, which means it does not reflect the real code coverage of the project.
Insight 📝
It was caused by the SimpleCov not starting before the Rails was loaded.
Proof Of Work 📹
Tested and worked well on the public repo