Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ./bin/dev.sh script in favor of the makefile #443

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Remove the ./bin/dev.sh script in favor of the makefile #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7bcb7b9
[#410] Remove bin/dev.sh and start foreman from makefile
mosharaf13 Jul 11, 2023
317f2e1
[#410] Remove test related to bin/dev file existence
mosharaf13 Jul 11, 2023
5cf54e5
[#410] Remove instructions about copying bin/dev
mosharaf13 Jul 11, 2023
6945e3b
[#410] Rename phrase add-on spec's template file
mosharaf13 Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...plate/spec/addons/base/phrase/template.rb → .../spec/addons/base/phrase/template_spec.rb
View file
Open in desktop
File renamed without changes.
5 changes: 0 additions & 5 deletions .template/spec/base/bin/template_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@
expect(file('bin/worker.sh')).to be_executable
end

it 'creates the start dev server script' do
expect(file('bin/dev')).to exist
expect(file('bin/dev')).to be_executable
end

it 'creates the docker prepare script' do
expect(file('bin/docker-prepare')).to exist
expect(file('bin/docker-prepare')).to be_executable
Expand Down
2 changes: 1 addition & 1 deletion Makefile.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ include .env
dev:
make install-dependencies
make env/setup
./bin/dev
foreman start -f Procfile.dev

env/setup:
./bin/envsetup.sh
Expand Down
3 changes: 0 additions & 3 deletions bin/dev
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion bin/template.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,5 @@
copy_file 'bin/start.sh', mode: :preserve
copy_file 'bin/test.sh', mode: :preserve
copy_file 'bin/worker.sh', mode: :preserve
copy_file 'bin/dev', mode: :preserve
copy_file 'bin/docker-prepare', mode: :preserve
copy_file 'bin/docker-assets-precompile', mode: :preserve