Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ./bin/dev.sh script in favor of the makefile #443

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Remove the ./bin/dev.sh script in favor of the makefile #443

merged 4 commits into from
Jul 13, 2023

Conversation

mosharaf13
Copy link
Contributor

close #410

What happened 👀

  • Move foreman start -f Procfile.dev from ./bin/dev.sh to Makefile
  • Remove ./bin/dev.sh

Insight 📝

Proof Of Work 📹

The server starts without any error
Screen Shot 2023-07-11 at 1 57 27 PM

@mosharaf13 mosharaf13 changed the title Remove the ./bin/dev.sh script in favor of the makefile [WIP] Remove the ./bin/dev.sh script in favor of the makefile Jul 11, 2023
@mosharaf13 mosharaf13 marked this pull request as draft July 11, 2023 07:03
@mosharaf13 mosharaf13 marked this pull request as ready for review July 11, 2023 08:16
@mosharaf13 mosharaf13 changed the title [WIP] Remove the ./bin/dev.sh script in favor of the makefile Remove the ./bin/dev.sh script in favor of the makefile Jul 11, 2023
malparty
malparty approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@malparty malparty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

tyrro
tyrro approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@tyrro tyrro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I am looking at the template_spec.rb in this PR, I came across another spec file that's named as template.rb, which should be template_spec.rb as per Rails convention:

https://github.com/nimblehq/rails-templates/blob/704ae5e347cf012eb63aa041ff4fc0a158fa446b/.template/spec/addons/base/phrase/template.rb

could you rename the above file to template_spec.rb, this is not related to this PR; but this is a very small change and makes the naming of test file consistent!

@malparty malparty added this pull request to the merge queue Jul 13, 2023
Merged via the queue into develop with commit 7f0c393 Jul 13, 2023
5 checks passed
@malparty malparty deleted the feature/gh410-remove-dev-script-in-favor-of-makefile branch July 13, 2023 09:24
@malparty malparty added this to the 5.7.0 milestone Jul 26, 2023
@malparty malparty mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrro tyrro tyrro approved these changes

@sanG-github sanG-github sanG-github approved these changes

@malparty malparty malparty approved these changes

@rosle rosle Awaiting requested review from rosle

@andyduong1920 andyduong1920 Awaiting requested review from andyduong1920 andyduong1920 is a code owner

@bterone bterone Awaiting requested review from bterone bterone is a code owner

@byhbt byhbt Awaiting requested review from byhbt byhbt is a code owner

@carryall carryall Awaiting requested review from carryall carryall is a code owner

@hoangmirs hoangmirs Awaiting requested review from hoangmirs hoangmirs is a code owner

@longnd longnd Awaiting requested review from longnd longnd is a code owner

Assignees

@mosharaf13 mosharaf13

Labels
type : chore
Projects
None yet
Milestone
5.7.0
Development

Successfully merging this pull request may close these issues.

Remove the ./bin/dev.sh script in favor of the makefile
4 participants
@mosharaf13 @tyrro @sanG-github @malparty