cbuilder: ccgexprs sweep part 1, basic if stmts #24381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code blow up is too much, use more helper procs please. |
|
The call & assignment builders have prebuilt argument versions now that are more readable but need more strings to be built, albeit not large ones. Some extra helpers are also added to deal with code duplication. Let me know if it's still not readable enough. |
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
This was referenced Oct 31, 2024
Araq
pushed a commit
that referenced
this pull request
Nov 3, 2024
Doing this early is useful so we can move the indentation logic into `Builder` itself rather than mix it with the block logic in `ccgstmts` (the `if` statements in #24381 have not been indented properly either). However it also means `Builder` is now used for code that still generates raw C code, so the diff won't be as clean when these get updated.
metagn
added a commit
that referenced
this pull request
Nov 3, 2024
Finishes `genEnumInfo` as followup to #24351. As #24381 mentions this covers every use of `for` loops in the codegen. --------- Co-authored-by: Andreas Rumpf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of what ccgexprs uses is now ported to cbuilder, so this PR makes around ~25% of ccgexprs use it, along with adding
ifstmts (nowhile/switchandforwhich is only used asfor (tmp = a; tmp < b; tmp++)). Theifbuilder does not add indents for blocks since we can't makeBuilderan object yet rather than an alias tostring, this will likely be one of the last refactors.Somewhat unrelated but
ccgtypesis not ready yet because proc signatures are not implemented.