Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cbuilder: ccgexprs sweep part 2 #24392

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Conversation

metagn
Copy link
Collaborator

@metagn metagn commented Oct 31, 2024

follows up #24381

This is about another 30% of ccgexprs (remaining is up to around line 3000), stopped right before the point where #24391 is required.

The Genode::log and Genode::Cstring calls in genEcho are left as is but could be mangled in the future.

@Araq
Copy link
Member

Araq commented Oct 31, 2024

I don't know how :: would translate to NIFC.

It will simply produce \<hex value of ':'> * 2 and make it part of the C name.

@metagn
Copy link
Collaborator Author

metagn commented Nov 1, 2024

Did the Genode echo too, the identifiers are left alone for now, in the future we will probably need to use some cIdent() wrapper for these direct uses of names that would include that transformation

@Araq Araq merged commit c8072b1 into nim-lang:devel Nov 1, 2024
18 of 19 checks passed
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from c8072b1

Hint: mm: orc; opt: speed; options: -d:release
176590 lines; 8.573s; 655.16MiB peakmem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants