-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MQTT Fixes from Abstract #571
base: main
Are you sure you want to change the base?
Conversation
I took a quick look and these changes are not compatible with paho mqtt client v2 and the MQTTv5 protocol. So this PR will probably only work for installs that are still using paho mqtt client v1. I will fix this when I have more time. |
It turned out to be an easy fix, see RichieB2B@69027ca and the paho migration documentation for reference. |
Incorporated -- thank you! |
Looks good, thanks @MikeBishop and @RichieB2B |
I tried this merged into my working branch (main + some PRs) and it seems to be working. Appreciate it if someone else can give it a try before we merge. |
This PR attempts to pull out all the MQTT-related changes from #483, other than #492. This without #492 might be somewhat inconsistent.
Draft because I haven't explicitly tested this yet, just done the work in git to lift it out.