Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stopAskingToStartCharging behaviour #589

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

RichieB2B
Copy link

See discussion in #575

2nd fix: set stopAskingToStartCharging when a vehicle is not at home so it is allowed to sleep remotely.

Copy link
Owner

@ngardiner ngardiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, agree with the direction re minimising unnecessary API calls

@MikeBishop
Copy link
Collaborator

Does setting this while not at home produce an actual behavior change? The lines as originally written will skip any car that's not at home already. Though since the car will attempt to charge when plugged in anyway, I suspect we don't lose anything by setting it here, either.

@RichieB2B
Copy link
Author

The change in behavior is that TWCManager stops trying to start a charge a car that is not at home. Right now it keeps polling the vehicle_data every minute, determines the location is not home, skips the car. Repeat.

I don't expect a change in the actual charges because stopAskingToStartCharging is reset when a car arrives home. And the charge will start when plugging in as you mentioned.

@RichieB2B
Copy link
Author

3rd fix: set vehicle lastErrorTime at 429 in wakeVehicle()
4th fix: increase cacheTime to 300 for vehicle_data

@MikeBishop
Copy link
Collaborator

This may interact with #571's statusDeferral, which reduces vehicle status checking to every hour if it's far away from home, and every half-hour if it's nearby but not actually driving. That said, assuming the vehicle will get plugged in upon arrival home and trigger a location update, completely muting vehicle_data checks when the car is away from home may be the more conservative solution.

@RichieB2B
Copy link
Author

RichieB2B commented Jun 13, 2024

5th fix: set carApiLastErrorTime at 429 in get_car_api()

Hopefully this all is enough to stay within the free API tier limits.

@RichieB2B
Copy link
Author

That said, assuming the vehicle will get plugged in upon arrival home and trigger a location update, completely muting vehicle_data checks when the car is away from home may be the more conservative solution.

I'm running the code in this PR since yesterday. My wife's MS started charging upon plugging in, my MY did not. Had to manually start the charge. Not good. The dashboard said "charging stopped" but there was no stop command in the TWCManager logs (simply no session start either). I'll keep testing this code.. my understanding is that a Tesla will always just start charing when plugged into a live charger. Might be a fluke. Otherwise #571 is a nice solution indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants