Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cellranger filename check #261

Merged
merged 3 commits into from
Aug 24, 2023
Merged

fix cellranger filename check #261

merged 3 commits into from
Aug 24, 2023

Conversation

grst
Copy link
Member

@grst grst commented Aug 24, 2023

  • bump version to 2.5.0dev
  • Update cellranger module

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/scrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@grst grst requested a review from vjmarteau August 24, 2023 12:15
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions
Copy link

Python linting (black) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install black: pip install black
  • Fix formatting errors in your pipeline: black .

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@grst grst changed the base branch from master to dev August 24, 2023 12:15
@github-actions
Copy link

github-actions bot commented Aug 24, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 0bf2013

+| ✅ 156 tests passed       |+
#| ❔   2 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-08-24 12:18:06

@grst grst merged commit 2c12201 into dev Aug 24, 2023
14 checks passed
@grst grst deleted the fix-cellranger-filename-check branch August 24, 2023 12:30
@grst grst mentioned this pull request Sep 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjmarteau vjmarteau vjmarteau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grst @vjmarteau