Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition nextclade 2->3 #54

Closed
wants to merge 1 commit into from
Closed

Transition nextclade 2->3 #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,11 @@ mkdir -p "$PREFIX"/bin
cp -v "$SRC_DIR"/envdir "$PREFIX"/bin/envdir

# Nextclade v3
curl -fsSL -o "$PREFIX"/bin/nextclade3 https://github.com/nextstrain/nextclade/releases/download/3.0.0-alpha.2/nextclade-$("$SRC_DIR"/target-triple)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the existing addition of nextclade3 here as temporary. I would just wait for Bioconda to be updated so nextclade is v3, remove this curl command, and rebuild a new version of nextstrain-base.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes exactly, recipe is approved over on bioconda, just be on the index in <1hr

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linking the Bioconda update here: bioconda/bioconda-recipes#45259

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be there any minute as PR has been merged

# TODO: Remove once bioconda has nextclade3
curl -fsSL -o "$PREFIX"/bin/nextclade3 https://github.com/nextstrain/nextclade/releases/download/3.0.0/nextclade-$("$SRC_DIR"/target-triple)
chmod a+rx "$PREFIX"/bin/nextclade3

# Nextclade v2
# TODO: Remove once nextclade2 package is added to recipe.yaml
curl -fsSL -o "$PREFIX"/bin/nextclade2 https://github.com/nextstrain/nextclade/releases/download/2.14.0/nextclade-$("$SRC_DIR"/target-triple)
chmod a+rx "$PREFIX"/bin/nextclade2