Transition nextclade 2->3 #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update nextclade3 version Add nextclade2 in build.sh for stability until bioconda update is sorted out
|
Re-running CI now that 3.0.0 is available. |
victorlin
requested changes
Jan 16, 2024
| @@ -6,5 +6,11 @@ mkdir -p "$PREFIX"/bin | |||
| cp -v "$SRC_DIR"/envdir "$PREFIX"/bin/envdir | |||
|
|
|||
| # Nextclade v3 | |||
| curl -fsSL -o "$PREFIX"/bin/nextclade3 https://github.com/nextstrain/nextclade/releases/download/3.0.0-alpha.2/nextclade-$("$SRC_DIR"/target-triple) | |||
There was a problem hiding this comment.
I see the existing addition of nextclade3 here as temporary. I would just wait for Bioconda to be updated so nextclade is v3, remove this curl command, and rebuild a new version of nextstrain-base.
There was a problem hiding this comment.
yes exactly, recipe is approved over on bioconda, just be on the index in <1hr
There was a problem hiding this comment.
Linking the Bioconda update here: bioconda/bioconda-recipes#45259
There was a problem hiding this comment.
should be there any minute as PR has been merged
|
I think we can now get rid of all the nextclade 2/3 downloading in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update nextclade3 version
Add nextclade2 in build.sh for stability until bioconda update is sorted out
Fails currently as we don't have the 3.0.0 gh release ye
Description of proposed changes
Related issue(s)
Checklist