-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(paste): collapse whitespace before pasting #4872
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-nextcloud
commented
Oct 17, 2023
Probably also will fix #4768. |
mejo-
reviewed
Oct 19, 2023
mejo-
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Max gave me a walkthrough through the code. Very clean and thorough solution, thanks a lot! Only nitpicking comments.
By default html does not display whitespace but text does. Remove newlines when pasting to ensure consistency with the previous display. Keep the newlines when they are also displayed in the source. * Resolves #4602. Signed-off-by: Max <[email protected]> Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
fix/4602-remove-newlines-in-pastes
branch
from
October 24, 2023 13:25
6d3fd63
to
a958e8a
Compare
/backport to stable27 |
/backport to stable26 |
2 tasks
Cypress failures are unrelated. |
This was referenced Oct 24, 2023
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
By default html does not display whitespace but text does. Remove newlines when pasting to ensure consistency with the previous display.
Keep the newlines when they are also displayed in the source.
white-space: pre-wrap
#4624🖼️ Screenshots
🏚️ Before
🏡 After
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)