Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NodeViewContent): Don't set white-space: pre-wrap #4624

Closed
wants to merge 2 commits into from

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Aug 2, 2023

Fixes: #4602

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@mejo- mejo- added bug Something isn't working 3. to review labels Aug 2, 2023
@mejo- mejo- added this to the Nextcloud 27.1.0 milestone Aug 2, 2023
@cypress
Copy link

cypress bot commented Aug 2, 2023

1 failed and 1 flaky tests on run #11478 ↗︎

1 148 2 0 Flakiness 1

Details:

fix(NodeViewContent): Don't set `white-space: pre-wrap`
Project: Text Commit: f319eaf9ec
Status: Failed Duration: 03:56 💡
Started: Aug 2, 2023 4:38 PM Ended: Aug 2, 2023 4:42 PM
Failed  cypress/e2e/MenuBar.spec.js • 1 failed test

View Output Video

Test Artifacts
Test the rich text editor menu bar > word count > single word Output Screenshots
Flakiness  cypress/e2e/api/SyncServiceProvider.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync service provider > recovers from a dropped message Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mejo-
Copy link
Member Author

mejo- commented Aug 2, 2023

/compile

Signed-off-by: nextcloud-command <[email protected]>
@mejo-
Copy link
Member Author

mejo- commented Aug 2, 2023

Unfortunately this seems to break pasting plaintext content with linebreaks.

@mejo-
Copy link
Member Author

mejo- commented Oct 24, 2023

We have a proper fix for this now in #4872.

@mejo- mejo- closed this Oct 24, 2023
@mejo- mejo- deleted the fix/nodeviewcontent branch October 24, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pasting paragraphs sometimes adds unexpected linebreaks
5 participants