fix: pass file id for direct editing and fail y.js provider setup if none was passed

[juliusknorr]

📝 Summary

When setting up the WebsocketProvider we still used to create them even if no file id was passed. This is actually the case for direct editing trough android/iOS and would mean that if some browser states in the webview is still present it could mix up documents.

This is basically a follow up to b2186da

• Possibly fixes Text 3.7.2: Files mixed or emptied #4112
• Possibly fixes parts of user cursors trigger different bugs (2023-05) #4100

🏁 Checklist

• Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
• Sign-off message is added to all commits
• Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
• Documentation (README or documentation) has been updated or is not required

[juliusknorr]

Note that the error behaviour is currently quite bad as when this happens the Editor.vue is just empty, will see if we can improve that as well.

[juliusknorr]

/backport to stable26

[cypress]

1 flaky tests on run #9681 ↗︎

0

142

1

0

1

Details:

fix: pass file id for direct editing and fail y.js provider setup if none was pa...
Project: Text	Commit: f725c78b95
Status: Passed	Duration: 03:40 💡
Started: May 5, 2023 3:39 PM	Ended: May 5, 2023 3:42 PM

  cypress/e2e/sync.spec.js • 1 flaky test

View Output Video

Test		Artifacts
Sync > recovers from a lost connection		Output Screenshots

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[mejo-]

Just a minor comment.

And to be honest I don't fully understand the situation. So directediting sessions didn't pass a fileId before the change to DirectEditing.vue from this PR, which lead to WebsocketProvider instances with similar identifiers, which in turn could result in content from leftover sessions getting mixed into the new session. Is this roughly the scenario that this PR aims to fix?

[juliusknorr]

Yes with the addition that the mobile apps might not immediately cleanup the old web view which I've seen happening on iOS for example.

This could also happen on desktop when users use the desktop client option for direct editing.

[mejo-]

Thanks ☺️

[mejo-]

/compile

[backportbot-nextcloud]

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[mejo-]

/backport 23a46cd to stable26

[max-nextcloud]

Great catch @juliushaertl and thanks for the quick review and backport @mejo- ! ❤️