Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user cursors trigger different bugs (2023-05) #4100

Closed
kolAflash opened this issue May 1, 2023 · 4 comments
Closed

user cursors trigger different bugs (2023-05) #4100

kolAflash opened this issue May 1, 2023 · 4 comments
Labels
1. to develop 26 feedback bug Something isn't working

Comments

@kolAflash
Copy link

kolAflash commented May 1, 2023

The new "user position indicator" feature triggers different bugs.

screenshot

Screenshot_20230501-222621_Nextcloud

 

Questions, Problems and Bugs

Questions:

  • What's the correct name for that feature!? (I just call it "User position indicator" because I don't know any other name for it)
  • Can the feature be disabled?
    • It's a nice feature. But for me it's not worth the problems and bugs it causes.
  • The indicators seem to go away 30 seconds after opening a document. Can that time span be changed?

 

Bugs:

  • Sometimes all text following an indicator is deleted. This seems to happen when editing text at the position of the indicator. (couldn't determine the exact circumstances until now)
  • In the browser (Firefox) empty lines containing an indicator can't be clicked.
  • Same user is listed multiple times, although he's just logged in from one client. (counted up to five)

 

Problems:

  • When an user position indicator overlaps text, the text can't be read.
  • Sometimes the same indicator seems to be multiple times at the same position. Clicking the first indicator in the screenshot (see above) on Android makes my keyboards auto completion show kolAflashkolAflashkolAflashkolAflashkolAflash. (5 times)

 

 

Tested platforms

  • PC (Firefox-112.0.2)
  • Android-10 (Nextcloud App 3.24.2)
  • Android-13 (Nextcloud App 3.24.2)

Server:
Nextcloud: 26.0.1
Text App: 3.7.2
OS: Debian-12 (Apache-2.4.57, php-fpm-8.2.4, mariadb-10.11.2)

@kolAflash kolAflash added the bug Something isn't working label May 1, 2023
@juliusknorr
Copy link
Member

Thanks for reporting, for the first issue it would be quite helpful to have more detailed steps, maybe also a short screen recording to see when this happens.

Same user is listed multiple times, although he's just logged in from one client. (counted up to five)

This has been addressed with #4053 already and will be fixed in the next maintenance release.

@kolAflash
Copy link
Author

kolAflash commented May 4, 2023

@juliushaertl
At first: Thank you very much for your help!
(I'm a little sleepy, so please excuse if my language is a little bad)

Here are some videos showing a wide range of problems.
Including the bug which deletes all text following the cursor.

The last video shows an additional problem I discovered:
The Android app shows a complete different file that has previously been edited.
Workaround: Force close the Android app.

What about my problems and questions? (aside from the hard bugs)
Can the user position indicator feature be disabled or the 30 seconds timeout be changed?
What to do about indicators overlapping text I'd like to read?

 

I'm sure those problems didn't exist two weeks before. They must have been introduced with a recent update (Android app or server). The only change I did aside from updating Nextcloud was to update the server from Debian-11 (PHP-7.4) to Debian-12 (PHP-8.2).

Maybe related: #4112 Text 3.7.2: Files mixed or emptied

P.S.
I'm not using Google GBoard keyboard since and because of:
nextcloud/android#8945 Text editor: GBoard Return key broken and may delete all text

FP3_Android-10_eOS-1.4.mp4
Pixel4a_Android-13.mp4
Pixel4a_Android-13_non-empty-new-file.mp4

@juliusknorr
Copy link
Member

Here are some videos showing a wide range of problems. Including the bug which deletes all text following the cursor.

Thanks a lot for that, sharing those insights and the videos are highly appreciated.

In order to address those properly I'd split them into individual tickets.

The last video shows an additional problem I discovered: The Android app shows a complete different file that has previously been edited. Workaround: Force close the Android app.

This looks like #4112 and I just a possible fix in #4124

What about my problems and questions? (aside from the hard bugs) Can the user position indicator feature be disabled or the 30 seconds timeout be changed? What to do about indicators overlapping text I'd like to read?

Currently not but I agree that this makes sense to have so I filed #4126 for that

FP3_Android-10_eOS-1.4.mp4

This looks like #1927

Pixel4a_Android-13.mp4

The issue with multiple cursors has been addressed with #4053

Pixel4a_Android-13_non-empty-new-file.mp4

As mentioned above this is likely resolved by #4124

I'd close this issue in favour of the individual ones. If you find further issues feel free to create new ones, ideally already separated in one github ticket per issue :)

@kolAflash kolAflash changed the title user position indicators triggers different bugs (what's that feature correctly called?) user cursors trigger different bugs (2023-05) May 6, 2023
@kolAflash
Copy link
Author

kolAflash commented May 6, 2023

@juliushaertl
Thanks a lot!
Also for splitting up everything. (I'll try to do that next time myself)

This broke a lot of my workflows.
I'm really relying on Nextcloud and the text app.
I've no use for software I can't rely on.
And I guess for many other people it's the same.
Would be very great if there will be an update soon!
And again thanks a lot for your work and responsiveness!

 

I've just applied this WORKAROUND:

  1. Download version for Nextcloud 25.0.6, containing the text app version 3.6.0.
  2. Extract and copy these folders and files into a new folder called text: appinfo babel.config.js CHANGELOG.md composer.json composer.lock COPYING css cypress.config.js img index.html jest-raw-loader.js js jsconfig.json krankerl.toml l10n lib templates vite.config.js
  3. Inside the text folder edit appinfo/info.xml and set max-version="26".
  4. Make a backup of the apps/text/ folder on your Nextcloud server and replace it with the newly created text folder.
  5. Call the Nextcloud webinterface as admin to run database migrations. (or run occ upgrade as www user)

P.S.
Works only for 30 seconds. Then I get a lastAwarenessMessage is not a valid attribute error in the nextcloud.log on the server and the client JavaScript crashes.

 

 

P.S.
I just found another bug. Sometimes when opening a definetly non empty TXT file the editor asks to use the current or the saved version. But choosing either answer gives me an empty file.
But I'll first see if the pending issues / merges might already fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop 26 feedback bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants