-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
29.0.5 Changes are not saved or detected when tab is inactive for more than 30 seconds #6280
Comments
This should have been addressed by #6205 As far as I'm aware there is a new release candidate scheduled for today for Nextcloud 29, so upgrading to that once released later today could help. |
👍 Thank you, then I will definitely try the RC today |
Just found the 28.x backport :-)
|
Let's close this for now. Please report back if this still happens on 29.0.6 or 28.0.9 after force-reloading (to ensure latest frontend assets are loaded). |
@mejo- |
@kolAflash I wonder if you're talking about a separate issue then. Does this happen with Collectives or with Text in the Files app, or both? |
@mejo- I just compiled 78f146197 myself with VueJS and replaced The NC-28.x backport (#6204) was merged 2024-08-28, which is after the 28.0.9 release (2024-08-20). So it's pretty clear that this isn't fixed in 28.0.9. |
Thanks for double-checking @kolAflash. I got confused by the unsynchronized NC 28 and 29 releases: Nextcloud 29.0.6 that ships the fix got released yesterday. You're correct that Nextcloud 28.0.10 (which also ships the fix) will only get released on 12. September. Also thanks for confirming that the backported patch fixes the issue ❤️ |
Here's the patched version I compiled for NC-28.x from 78f146197:
@mejo- If you like to do me a favour, please improve the QA / quality assurance for the text app. |
Thanks for your honest feedback @kolAflash! We're aware that the text app suffered from major bugs within the last year, and we're deeply sorry about that. We continue to improve the QA situation and we can assure you that we're doing lots of testing each time we change something in the sync session handling code. Unfortunately we don't know all possible scenarios upfront, so we continue to learn with each bug that gets discovered. |
Describe the bug
When leaving a tab with an open document for more than 30 seconds, new changes are not detected when returning to it.
This is easiest to see when the document was saved right before leaving the tab, as this removes the blue dot indicating that there are unsaved changes. When returning to the tab, the blue dot does not reappear.
But the same thing happens when not having saved before leaving the tab.
This started to occur after upgrading to NC 29.0.5 from 29.0.3.
This issue occurs on the instance upgraded from 29.0.3 and on a fresh install of 29.0.4.
I could not reproduce this on a fresh install of 29.0.4
I hope I have provided enough information. If anything is missing or unclear I am happy to try and provide more information.
We use this tool quite a lot and this problem sadly makes the tool currently unusable for us, so I would be grateful if somebody has an idea for a quick workaround.
Thank you for your help 😃
To Reproduce
Expected behavior
When switching tab for more than 30 seconds one should be able to continue editing the document.
When trying the same thing in NC 29.0.4 the document is marked as dirty/having unsaved changes upon returning to the tab.
Screenshots
nc-29.0.5-text-changes-not-detected.webm
Server details:
Client details:
Logs
Nextcloud log (data/nextcloud.log)
Browser log
browser_log_har.tar.gz
Javascript Console Log
The text was updated successfully, but these errors were encountered: