Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup spell checker for localizable file #1403

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Setup spell checker for localizable file #1403

merged 1 commit into from
Oct 27, 2023

Conversation

SystemKeeper
Copy link
Collaborator

@SystemKeeper SystemKeeper commented Oct 26, 2023

Add spell check to localizable CI. Added it there to always check with the latest localizable file (otherwise the run would first fail for not correctly updating the localizable file and then for spell checking).

Test of failure: https://github.com/nextcloud/talk-ios/actions/runs/6657060665/job/18090981017?pr=1403

@SystemKeeper
Copy link
Collaborator Author

CC @rakekniven

@rakekniven
Copy link
Member

Hello @SystemKeeper ,

really appreciate you picked up my comment and added something right away.

Does that mean something similar has to be added for each repo?
If so, is there any mechanism to have that globally for all NC apps incl. server? (dreaming in the clouds 😄 )

Signed-off-by: Marcel Müller <[email protected]>
@Ivansss Ivansss merged commit e32e978 into master Oct 27, 2023
6 checks passed
@Ivansss Ivansss deleted the spelling-ci branch October 27, 2023 14:02
@SystemKeeper
Copy link
Collaborator Author

If so, is there any mechanism to have that globally for all NC apps incl. server? (dreaming in the clouds 😄 )

Indeed there are templates for CI. The main issue I see is adjusting a spell checker to the corresponding repository. In iOS it's quite easy, there's a single file that's generated and committed and is the only one that needs to be checked. AFAIK on a javascript project these strings are extracted from the source files directly by the transifex job, so not sure how this would be set up there. Another issue might be resources on CI, on busy days there's already quite some waiting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants