Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup spell checker for localizable file #1403

Merged
merged 1 commit into from
Oct 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/localizable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,18 @@ jobs:
run: |
git diff

- name: Install dependencies
run: |
pip3 install pyspelling

- name: Spell check
run: |
python3 -m pyspelling

- name: Verify Changed files
uses: tj-actions/verify-changed-files@v16
id: verify-changed-files
if: always()
with:
fail-if-changed: true
files: |
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ NextcloudTalk.xcworkspace/xcshareddata
ThirdParty/WebRTC.xcframework
.DS_Store
testResult.xcresult
dictionary.dic
13 changes: 13 additions & 0 deletions .pyspelling.wordlist.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
AirPlay
Cancelled
HPB
Matterbridge
Nextcloud
Repo
backend
formattedPhoneNumber
https
ld
listable
lu
decrypted
10 changes: 10 additions & 0 deletions .pyspelling.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
matrix:
- name: English localizable file
aspell:
lang: en
d: en_US
dictionary:
wordlists:
- .pyspelling.wordlist.txt
sources:
- NextcloudTalk/en.lproj/Localizable.strings
2 changes: 1 addition & 1 deletion NextcloudTalk/CallKitManager.m
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ - (void)reportIncomingCallForNonCallKitDevicesWithPushNotification:(NCPushNotifi
- (void)reportIncomingCallForOldAccount
{
CXCallUpdate *update = [self defaultCallUpdate];
update.localizedCallerName = NSLocalizedString(@"Old account", @"Will be used as the caller name when a voip notification can't be decrypted");
update.localizedCallerName = NSLocalizedString(@"Old account", @"Will be used as the caller name when a VoIP notification can't be decrypted");

NSUUID *callUUID = [NSUUID new];
CallKitCall *call = [[CallKitCall alloc] init];
Expand Down
4 changes: 2 additions & 2 deletions NextcloudTalk/en.lproj/Localizable.strings
Original file line number Diff line number Diff line change
Expand Up @@ -1189,7 +1189,7 @@
/* No comment provided by engineer. */
"OK" = "OK";

/* Will be used as the caller name when a voip notification can't be decrypted */
/* Will be used as the caller name when a VoIP notification can't be decrypted */
"Old account" = "Old account";

/* No comment provided by engineer. */
Expand Down Expand Up @@ -1624,7 +1624,7 @@
/* No comment provided by engineer. */
"To resolve this issue, use the web interface and go to \"Settings -> Security\"." = "To resolve this issue, use the web interface and go to \"Settings -> Security\".";

/* TRANSLATORS this is for sending something 'to' a user. Eg. 'To: John Doe' */
/* TRANSLATORS this is for sending something 'to' a user. E.g. 'To: John Doe' */
"To:" = "To:";

/* No comment provided by engineer. */
Expand Down
2 changes: 1 addition & 1 deletion ShareExtension/ShareConfirmationViewController.m
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ - (void)viewDidLoad
NSDictionary *subAttribute = @{NSFontAttributeName:[UIFont boldSystemFontOfSize:15],
NSForegroundColorAttributeName:[UIColor tertiaryLabelColor]};

NSString *localizedToString = NSLocalizedString(@"To:", @"TRANSLATORS this is for sending something 'to' a user. Eg. 'To: John Doe'");
NSString *localizedToString = NSLocalizedString(@"To:", @"TRANSLATORS this is for sending something 'to' a user. E.g. 'To: John Doe'");
NSMutableAttributedString *toString = [[NSMutableAttributedString alloc] initWithString:[NSString stringWithFormat:@"%@ %@", localizedToString, _room.displayName] attributes:attributes];
[toString addAttributes:subAttribute range:NSMakeRange(0, [localizedToString length])];
self.toLabel.attributedText = toString;
Expand Down
Loading