Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve and reverse wording of microphone toggle button (participants) #13241

Closed
wants to merge 2 commits into from
Closed

Improve and reverse wording of microphone toggle button (participants) #13241

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92ed83a
Improve and reverse the wording of the microphone toggle button for p…
Jerome-Herbinet Sep 9, 2024
5da1ea7
Replace "unmute" with "muted" because moderator can't unmute
Jerome-Herbinet Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/CallView/shared/VideoBottomBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,8 @@ export default {
},
audioButtonTooltip() {
return this.model.attributes.audioAvailable
? t('spreed', 'Mute')
Copy link
Contributor

@Antreesy Antreesy Sep 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is correct for moderators. They have option to switch muted state for participant (it show Mute as an action)
image
But it happens remotely, so moderators can't turn it back (it is disabled and show Muted as a state):
image

Normal participants don't see this button at all

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so please check my last commit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, it was correct (as per screenshots).
this.model.attributes.audioAvailable === true => button is active => tooltip indicates action 'Mute'
this.model.attributes.audioAvailable === false => button is disabled => tooltip indicates state 'Muted'

Am I missing something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I must be pretty tired already at the beginning of the week. It's not your fault, it's mine ; my neurons aren't doing their job properly 😅, because I don't quite understand our conversation.

Just tell me what I need to change and I'll make a final commit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's something needed to be changed)

If microphone is ON, tooltip should be "Mute".
If microphone is OFF, tooltip should be "Muted".

Copy link
Member Author

@Jerome-Herbinet Jerome-Herbinet Sep 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I suggest closing the PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. But thanks for the effort anyway! If you'll find something else, don't hesitate to drop us a message in community chats

: t('spreed', 'Muted')
? t('spreed', 'Muted')
: t('spreed', 'Mute')
},

// Video indicator
Expand Down
Loading