Improve and reverse wording of microphone toggle button (participants) #13241
Conversation
…articipants Signed-off-by: Jérôme Herbinet <[email protected]>
Jerome-Herbinet
added
design
enhancement
feature: frontend 🖌️
| @@ -212,8 +212,8 @@ export default { | |||
| }, | |||
| audioButtonTooltip() { | |||
| return this.model.attributes.audioAvailable | |||
| ? t('spreed', 'Mute') | |||
There was a problem hiding this comment.
It is correct for moderators. They have option to switch muted state for participant (it show Mute as an action)
But it happens remotely, so moderators can't turn it back (it is disabled and show Muted as a state):
Normal participants don't see this button at all
There was a problem hiding this comment.
OK, so please check my last commit.
There was a problem hiding this comment.
Again, it was correct (as per screenshots).
this.model.attributes.audioAvailable === true => button is active => tooltip indicates action 'Mute'
this.model.attributes.audioAvailable === false => button is disabled => tooltip indicates state 'Muted'
Am I missing something?
There was a problem hiding this comment.
I'm sorry, I must be pretty tired already at the beginning of the week. It's not your fault, it's mine ; my neurons aren't doing their job properly 😅, because I don't quite understand our conversation.
Just tell me what I need to change and I'll make a final commit.
There was a problem hiding this comment.
I don't think there's something needed to be changed)
If microphone is ON, tooltip should be "Mute".
If microphone is OFF, tooltip should be "Muted".
There was a problem hiding this comment.
OK I suggest closing the PR.
There was a problem hiding this comment.
Ok. But thanks for the effort anyway! If you'll find something else, don't hesitate to drop us a message in community chats
Signed-off-by: Jérôme Herbinet <[email protected]>
I need reviewers to test it.
Go to the grid participants' view and check the microphone icon at the bottom right corner of the participant.
The main goal of this PR is to make sure that the tooltips' wordings indicate an action but not a state.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required