Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AppFramework): Add full support for date / time / datetime columns #47329

Merged
merged 4 commits into from
Oct 18, 2024
Merged

feat(AppFramework): Add full support for date / time / datetime columns #47329

merged 4 commits into from
Oct 18, 2024

Commits on Oct 17, 2024

  1. feat(AppFramework): Add full support for date / time / datetime columns 

    This adds support for all Doctrine supported types, for the column types only the immutable variants needed to be added.
But especially those types are the important ones, as our **Entity** class works by detecting changes through setters.
Meaning if it is mutable, changes like `$entity->date->modfiy()` can not be detected, so the immutable types make more sense here.

Similar the parameter types needed to be added.

`Enity` and `QBMapper` needed to be adjusted so they support (auto map) those types, required when insert or update an entity.

Also added more tests, especially to make sure the mapper really serializes the values correctly.

Co-authored-by: Ferdinand Thiessen <[email protected]>
Co-authored-by: Côme Chilliet <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux @come-nc
    susnux and come-nc committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    ee02e32 View commit details
    Browse the repository at this point in the history

  2. fix: Adjust parameter type usage and add SQLite support 

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e314d52 View commit details
    Browse the repository at this point in the history

  3. fix: Prevent breaking change in IQueryBuilder 

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    db94e10 View commit details
    Browse the repository at this point in the history

  4. fix: Adjust Entity types 

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    @susnux
    susnux committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    0e54c2b View commit details
    Browse the repository at this point in the history