feat(AppFramework): Add full support for date / time / datetime columns #47329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
nickvergessen,
Altahrim,
juliushaertl and
come-nc
susnux
force-pushed
the
feat/add-datetime-qbmapper-support
branch
from
2346049
to
2d9b552
Compare
|
The next major (which we will have to update to soon) changed behaviour of DateTime: https://github.com/doctrine/dbal/blob/4.1.x/UPGRADE.md#bc-break-stricter-datetime-types |
|
@nickvergessen this is what I implemented already, whats breaking is that |
come-nc
approved these changes
Aug 20, 2024
susnux
force-pushed
the
feat/add-datetime-qbmapper-support
branch
5 times, most recently
from
e62ee82
to
c059051
Compare
|
susnux
commented
Aug 21, 2024
susnux
force-pushed
the
feat/add-datetime-qbmapper-support
branch
from
478135b
to
87fb634
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
susnux
force-pushed
the
feat/add-datetime-qbmapper-support
branch
from
3046e20
to
a236626
Compare
susnux
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
This adds support for all Doctrine supported types, for the column types only the immutable variants needed to be added. But especially those types are the important ones, as our **Entity** class works by detecting changes through setters. Meaning if it is mutable, changes like `$entity->date->modfiy()` can not be detected, so the immutable types make more sense here. Similar the parameter types needed to be added. `Enity` and `QBMapper` needed to be adjusted so they support (auto map) those types, required when insert or update an entity. Also added more tests, especially to make sure the mapper really serializes the values correctly. Co-authored-by: Ferdinand Thiessen <[email protected]> Co-authored-by: Côme Chilliet <[email protected]> Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/add-datetime-qbmapper-support
branch
from
a236626
to
45e799b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds support for all Doctrine supported types, for the column types only the immutable variants needed to be added. But especially those types are the important ones, as our Entity class works by detecting changes through setters. Meaning if it is mutable, changes like
$entity->date->modfiy()can not be detected, so the immutable types make more sense here.Similar the parameter types needed to be added.
EnityandQBMapperneeded to be adjusted so they support (auto map) those types, required when insert or update an entity.Also added more tests, especially to make sure the mapper really serializes the values correctly.
Checklist