fix: Bring back federated editing in viewer iframe #3669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
fix/federation
branch
from
a02c4b1
to
f0dce12
Compare
juliusknorr
changed the title
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
juliusknorr
force-pushed
the
fix/federation
branch
2 times, most recently
from
0b01916
to
7196e7e
Compare
juliusknorr
commented
Aug 20, 2024
| #[PublicPage] | ||
| #[NoCSRFRequired] | ||
| public function remotePost(string $shareToken, string $remoteServer, string $remoteServerToken, ?string $filePath = null): TemplateResponse { | ||
| return $this->remote($shareToken, $remoteServer, $remoteServerToken, $filePath); |
There was a problem hiding this comment.
This is needed as currently the routing cannot handle two routes with the same controller method name. We need one for POST and one for GET
juliusknorr
commented
Aug 20, 2024
Signed-off-by: Julius Härtl <[email protected]> chore: Move to route attributes Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
fix/federation
branch
2 times, most recently
from
845e677
to
8345f16
Compare
This reverts commit f790b57. Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
fix/federation
branch
from
8345f16
to
72b5773
Compare
juliusknorr
added
3. to review
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
mejo-
approved these changes
Aug 21, 2024
AndyScherzinger
approved these changes
Aug 21, 2024
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick attempt to fix #3605
Ideally we'd also remove the document.js usage there, but this at least brings back the functionality.