Skip to content

Commit

Permalink
Revert "ci: Fix selector for saveas button"
Browse files Browse the repository at this point in the history
This reverts commit f790b57.

Signed-off-by: Julius Härtl <[email protected]>
  • Loading branch information
juliusknorr committed Aug 20, 2024
1 parent 6bcd4b0 commit 7196e7e
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
1 change: 1 addition & 0 deletions .github/workflows/cypress-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ jobs:
CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
SPLIT: 3
SPLIT_INDEX: ${{ env.container_index }}
CODE_RELEASE: ${{ matrix.code-image }}

- name: Upload test failure screenshots
uses: actions/upload-artifact@v2
Expand Down
14 changes: 9 additions & 5 deletions cypress/e2e/integration.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
* SPDX-FileCopyrightText: 2023 Julius Härtl <[email protected]>
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
const isNightly = Cypress.env('CODE_RELEASE') === 'nightly'

describe('Nextcloud integration', function() {
let randUser

Expand Down Expand Up @@ -61,19 +63,21 @@ describe('Nextcloud integration', function() {
cy.get('#tab-version_vue .version__info__label').contains('Current version')
})

// Currently it seems that Collabora is missing the save as button
it('Save as', function() {
// Grouped save button is currently only fixed on Collabora nightly
const exportFilename = isNightly ? 'document.rtf' : 'document.odt'
cy.get('@loleafletframe').within(() => {
cy.get('#File-tab-label').click()
cy.get('#file-saveas').click()
// FIXME: Seems currently broken, so let's skip this step
// cy.get('#saveas-entries #saveas-entry-1').click()
if (isNightly) {
cy.get('#saveas-entries #saveas-entry-1').click()
}
})

cy.get('.saveas-dialog').should('be.visible')
cy.get('.saveas-dialog input[type=text]')
.should('be.visible')
.should('have.value', '/document.odt')
.should('have.value', `/${exportFilename}`)

cy.get('.saveas-dialog button.button-vue--vue-primary').click()

Expand All @@ -85,7 +89,7 @@ describe('Nextcloud integration', function() {
// FIXME: We should not need to reload
cy.get('.breadcrumb__crumbs a').eq(0).click({ force: true })

cy.openFile('document.odt')
cy.openFile(exportFilename)
})

it('Open locally', function() {
Expand Down

0 comments on commit 7196e7e

Please sign in to comment.