Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve macOS Sparkle updater #5468

Merged
merged 15 commits into from
Jul 22, 2023
Merged

Improve macOS Sparkle updater #5468

merged 15 commits into from
Jul 22, 2023

Commits on Jul 22, 2023

  1. Use std::unique_ptr in sparkle updater class rather than manual manag… 

    …ement

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra @mgallien
    claucambra authored and mgallien committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    88b2ae0 View commit details
    Browse the repository at this point in the history

  2. Name sparkle updater delegate more reasonably 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra @mgallien
    claucambra authored and mgallien committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    aa3b315 View commit details
    Browse the repository at this point in the history

  3. Replace private class with an interfacing class to bridge Obj-C deleg… 

    …ate class and owner CPP class

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra @mgallien
    claucambra authored and mgallien committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    427ed0d View commit details
    Browse the repository at this point in the history

  4. Add q pointer to SparkleInterface 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra @mgallien
    claucambra authored and mgallien committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    85f8332 View commit details
    Browse the repository at this point in the history

  5. Add ability for sparkle updater to notify UI when state has changed 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra @mgallien
    claucambra authored and mgallien committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    40f7da0 View commit details
    Browse the repository at this point in the history

  6. Properly display status string for changes in updater 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra @mgallien
    claucambra authored and mgallien committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    5f87f66 View commit details
    Browse the repository at this point in the history

  7. Also record sparkle updater state 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra @mgallien
    claucambra authored and mgallien committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    73c4271 View commit details
    Browse the repository at this point in the history

  8. Implement proper notifying of sparkle updater state changes 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra @mgallien
    claucambra authored and mgallien committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    07ac1b8 View commit details
    Browse the repository at this point in the history

  9. Only enable check for update button when the sparkle updater is not w… 

    …orking

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra @mgallien
    claucambra authored and mgallien committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    5ff0191 View commit details
    Browse the repository at this point in the history

  10. Fix qbytearray related clazy warnings in objective-c++ sparkle update… 

    …r side

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra @mgallien
    claucambra authored and mgallien committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    5f9837b View commit details
    Browse the repository at this point in the history

  11. Only instantiate sparkle updater if autoupdating is available 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra @mgallien
    claucambra authored and mgallien committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    c927574 View commit details
    Browse the repository at this point in the history

  12. Properly handle skipping auto update checks in the sparkle updater 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra @mgallien
    claucambra authored and mgallien committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    892abd9 View commit details
    Browse the repository at this point in the history

  13. Fix localisation of updater status strings 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra @mgallien
    claucambra authored and mgallien committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    70cc0bf View commit details
    Browse the repository at this point in the history

  14. Clean up declaration in SparkleUpdater header 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra @mgallien
    claucambra authored and mgallien committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    ff1fbda View commit details
    Browse the repository at this point in the history

  15. Convert directly from QUrl to NSURL 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra @mgallien
    claucambra authored and mgallien committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    298a0f4 View commit details
    Browse the repository at this point in the history