Improve macOS Sparkle updater #5468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5468 +/- ##
==========================================
+ Coverage 60.05% 60.08% +0.03%
==========================================
Files 145 145
Lines 18762 18762
==========================================
+ Hits 11267 11273 +6
+ Misses 7495 7489 -6 |
|
SonarCloud Quality Gate failed. |
claucambra
force-pushed
the
work/sparkle-bumps
branch
from
a1365fc
to
7a73120
Compare
|
SonarCloud Quality Gate failed. |
|
We are still eagerly awaiting this fix, could this please get some attention again? :) |
claucambra
force-pushed
the
work/sparkle-bumps
branch
from
7a73120
to
6677052
Compare
mgallien
force-pushed
the
work/sparkle-bumps
branch
from
6677052
to
e850628
Compare
mgallien
approved these changes
Jul 22, 2023
…ement Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
…ate class and owner CPP class Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
…orking Signed-off-by: Claudio Cambra <[email protected]>
…r side Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
mgallien
force-pushed
the
work/sparkle-bumps
branch
from
e850628
to
298a0f4
Compare
|
AppImage file: nextcloud-PR-5468-298a0f4dfb0b6ad7c79f087497c19a5a1aafe653-x86_64.AppImage |
|
SonarCloud Quality Gate failed.
|
|
/backport to stable-3.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current implementation of the sparkle updater is not optimal. It does not communicate with our Qt GUI at all which leads to things like the update status QLabel in the settings window not being updated, and the "Check for updates" button being permanently disabled. Additionally, our handling of edge cases such as the application not being put in the
Applicationsfolder is not goodThis PR addresses these issues and improves our integration with the updater; it also fixes several internal updater and UI bugs along the way
Fixes #5429