Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/improve network error handling #5036

Merged
merged 6 commits into from
Jun 28, 2023
Merged

Feature/improve network error handling #5036

merged 6 commits into from
Jun 28, 2023

Commits on Jun 28, 2023

  1. fix ignored signals due to using old connect syntax 

    Signed-off-by: Matthieu Gallien <[email protected]>
    @mgallien
    mgallien committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    69d2b06 View commit details
    Browse the repository at this point in the history

  2. declare state property in AccountState 

    should make it more logic to find the property when needed

Signed-off-by: Matthieu Gallien <[email protected]>
    @mgallien
    mgallien committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    8cf778b View commit details
    Browse the repository at this point in the history

  3. ActivityListModel now keeps track of the account connection state 

    Signed-off-by: Matthieu Gallien <[email protected]>
    @mgallien
    mgallien committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    431ccfe View commit details
    Browse the repository at this point in the history

  4. add more metadata to sync errors to allow filtering 

    in order to be able to filter some errors when showing them into the
main dialog activity list, add some more info about the error to know
the origin (like a network issue or a sync issue)

Signed-off-by: Matthieu Gallien <[email protected]>
    @mgallien
    mgallien committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    0e002f3 View commit details
    Browse the repository at this point in the history

  5. filter out some errors if they are related to network troubles 

    Signed-off-by: Matthieu Gallien <[email protected]>
    @mgallien
    mgallien committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    cd6ee68 View commit details
    Browse the repository at this point in the history

  6. remove wrong code 

    Signed-off-by: Matthieu Gallien <[email protected]>
    @mgallien
    mgallien committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    033a37e View commit details
    Browse the repository at this point in the history